Skip to contentSkip to conversation

Prodif Plus device-ID cleanup and MODULE_DEVICE_TABLE() - macro

PATCH In review Henrik Kretzschmar 2 participants 3 messages Jun 27, 2006 – Jun 28, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Prodif Plus device-ID cleanup and MODULE_DEVICE_TABLE() - macro

Hi there!

This week I got a Prodif Plus and tried it out with ALSA. There seems to be some work to do to get it run again,
so here is the first patch.
Is there somebody else using this driver?
---
From: Henrik Kretzschmar <[email protected]>

Some pci_device_id cleanups and adding MODULE_DEVICE_ID() macro.

---

pci/pdplus/pdplus.c +4 -7
@@ -6174,16 +6174,13 @@
         LEAVE_VOID;
 }
 
-static struct pci_device_id pdplus_ids[] = {
-        {
-                PCI_VENDOR_ID_MARIAN,
-                PCI_DEVICE_ID_MARIAN_PRODIF_PLUS,
-                PCI_ANY_ID, PCI_ANY_ID,
-                0, 0, 0,
-        },
+static struct pci_device_id pdplus_ids[] __devinitdata = {
+        { 0x1382, 0x2048, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0, },
         { 0, }
 };
 
+MODULE_DEVICE_TABLE(pci, pdplus_ids);
+
 /* ********************************************************************** */
 
 static struct pci_driver driver = {

Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

#1 lore raw

At Tue, 27 Jun 2006 19:43:22 +0200,

Quoted 4 lines · Henrik Kretzschmar

Hi there!

This week I got a Prodif Plus and tried it out with ALSA.

Great, finally someone can test the driver again...

Quoted 2 lines

There seems to be some work to do to get it run again,
so here is the first patch.

The trend is to use PCI_DEVICE() macro with PCI_VENDOR_ID_* and PCI_DEVICE_ID* definitions.

Takashi

Quoted 32 lines

Is there somebody else using this driver?
---
From: Henrik Kretzschmar <[email protected]>

Some pci_device_id cleanups and adding MODULE_DEVICE_ID() macro.

---

pci/pdplus/pdplus.c +4 -7
@@ -6174,16 +6174,13 @@
         LEAVE_VOID;
 }
 
-static struct pci_device_id pdplus_ids[] = {
-        {
-                PCI_VENDOR_ID_MARIAN,
-                PCI_DEVICE_ID_MARIAN_PRODIF_PLUS,
-                PCI_ANY_ID, PCI_ANY_ID,
-                0, 0, 0,
-        },
+static struct pci_device_id pdplus_ids[] __devinitdata = {
+        { 0x1382, 0x2048, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0, },
         { 0, }
 };
 
+MODULE_DEVICE_TABLE(pci, pdplus_ids);
+
 /* ********************************************************************** */
 
 static struct pci_driver driver = {
Quoted 9 lines

Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

#2 lore raw

At Wed, 28 Jun 2006 14:12:16 +0200,

Quoted 8 lines · I wrote:

At Tue, 27 Jun 2006 19:43:22 +0200,

Quoted 4 lines · Henrik Kretzschmar

Hi there!

This week I got a Prodif Plus and tried it out with ALSA.

Quoted 7 lines

Great, finally someone can test the driver again...

Quoted 2 lines

There seems to be some work to do to get it run again,
so here is the first patch.

The trend is to use PCI_DEVICE() macro with PCI_VENDOR_ID_* and PCI_DEVICE_ID* definitions.

... and I commited the patch below to HG repo now.

Takashi

pci/pdplus/pdplus.c +3 -6
diff -r 56f16985aeae pci/pdplus/pdplus.c
@@ -6175,14 +6175,11 @@ static void __devexit pdplus_remove(pci_
 }
 
 static struct pci_device_id pdplus_ids[] = {
-        {
-                PCI_VENDOR_ID_MARIAN,
-                PCI_DEVICE_ID_MARIAN_PRODIF_PLUS,
-                PCI_ANY_ID, PCI_ANY_ID,
-                0, 0, 0,
-        },
+        { PCI_DEVICE(PCI_VENDOR_ID_MARIAN, PCI_DEVICE_ID_MARIAN_PRODIF_PLUS) },
         { 0, }
 };
+
+MODULE_DEVICE_TABLE(pci, pdplus_ids);
 
 /* ********************************************************************** */
 

Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642