Longhaul - infrastructure(?) proposal
Hello!
In case that flushing and disabling caches will not work. It is possible that I do above in wrong way. Would this code below be acceptable as infrastructure? Is this infrastructure or maybe hack?
This is draft/proposal.
Can I continue in this way or I shouldn't?
Rafa³
---
/*
* Longhaul "infrastructure" for bus master DMA */
struct longhaul_work {
struct list_head entry;
struct work_struct work;
struct longhaul_data *data;
void (*device_func) (void *data);
void *device_data;
};struct longhaul_data {
struct workqueue_struct *wq;
spinlock_t lock;
struct list_head work_unused;
struct list_head work_inuse;
struct list_head work_used;
};/* Access control for PCI bus */
static struct rw_semaphore longhaul_sem;
struct longhaul_data *longhaul_bmdma_register(char *name)
{
struct longhaul_data *longdata;
struct longhaul_work *longwork;
struct workqueue_struct *workqueue;
longdata = kmalloc(sizeof(struct longhaul_data), GFP_KERNEL);
if (longdata == NULL)
return NULL;
spin_lock_init(&longdata->lock);
INIT_LIST_HEAD(&longdata->work_unused);
INIT_LIST_HEAD(&longdata->work_inuse);
INIT_LIST_HEAD(&longdata->work_used);
longwork = kmalloc(sizeof(struct longhaul_work), GFP_KERNEL);
if (longwork == NULL) {
goto free_longdata;
}
INIT_WORK(&longwork->work, &longhaul_bmdma_work, NULL);
list_add(longwork, &longdata->work_unused);
longwork->data = longdata;
workqueue = create_singlethread_workqueue(name);
if (workqueue == NULL) {
printk(KERN_ERR PFX "Can't create workqueue \"%s\".\n", name);
goto free_longwork;
}
longdata->wq = workqueue;
return longdata;free_longwork:
kfree(longwork); free_longdata: kfree(longdata); return NULL; }
EXPORT_SYMBOL(longhaul_bmdma_register);
void longhaul_bmdma_unregister(struct longhaul_data *longdata) {
}EXPORT_SYMBOL(longhaul_bmdma_unregister);
static void longhaul_bmdma_work(void *data)
{
struct longhaul_work *longwork = data;
struct longhaul_data *longdata = longwork->data;
unsigned long flags;
down_read(&longhaul_sem);
longdata->device_func(longdata->device_data);
spin_lock_irqsave(&longdata->lock, flags);
list_move(longwork, &longdata->work_used);
spin_unlock_irqrestore(&longdata->lock, flags);
}int longhaul_bmdma_begin(struct longhaul_data *longdata,
void (*device_func) (void *data),
void *device_data);
{
struct longhaul_work *longwork;
unsigned long flags;
spin_lock_irqsave(&longdata->lock, flags);
if ( list_empty(&longdata->work_unused) ) {
longwork = kmalloc(sizeof(struct longhaul_work), GFP_ATOMIC);
if (longwork == NULL) {
spin_unlock_irqrestore(&longdata->lock, flags);
return -ENOMEM;
}
INIT_WORK(&longwork->work, &longhaul_bmdma_work, NULL);
longwork->data = longdata;
list_add(longwork, &longdata->work_inuse);
} else {
longwork = longdata->work_unused->next;
list_move(longwork, &longdata->work_inuse);
}
spin_unlock_irqrestore(&longdata->lock, flags);
longwork->device_func = device_func;
longwork->device_data = device_data;
PREPARE_WORK(longwork, &longhaul_bmdma_work, (void*)longwork);
queue_work(longdata->wq, longwork);
return 0;
}EXPORT_SYMBOL(longhaul_bmdma_begin);
void longhaul_bmdma_end(struct longhaul_data *longdata)
{
struct list_head pos;
unsigned long flags;
spin_lock_irqsave(&longdata->lock, flags);
if ( !list_empty(&longdata->work_used) ) {
list_for_each(pos, &longdata->work_used) {
list_move(longwork, &longdata->work_unused);
}
}
spin_unlock_irqrestore(&longdata->lock, flags);
up_read(&longhaul_sem);
}EXPORT_SYMBOL(longhaul_bmdma_end);
----------------------------------------------------------------------
PS. Fajny portal... >>> http://link.interia.pl/f196a
Quoted 8 lines · RafaÅ‚ Bilski
Hello!
In case that flushing and disabling caches will not work. It is possible that I do above in wrong way. Would this code below be acceptable as infrastructure? Is this infrastructure or maybe hack?
This is draft/proposal.
Can I continue in this way or I shouldn't?
I suggest to keep talking with Greg, as any work on quiescing dma will need cooperation from both USB & PCI layers, and he's one of the more knowledgable people in the area of the driver model.
Dave
Signature · 1 line
http://www.codemonkey.org.uk