Skip to contentSkip to conversation

pnxrgbfb: Remove tty.h from #include

PATCH In review Antonino A. Daplas 2 participants 3 messages Jul 2, 2006 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pnxrgbfb: Remove tty.h from #include

Framebuffer drivers should have no dependencies on the tty layer.

---

 drivers/video/pnx4008/pnxrgbfb.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/video/pnx4008/pnxrgbfb.c +0 -1
index 4bb7ad1..7d9453c 100644
@@ -18,7 +18,6 @@ #include <linux/kernel.h>
 #include <linux/errno.h>
 #include <linux/string.h>
 #include <linux/mm.h>
-#include <linux/tty.h>
 #include <linux/slab.h>
 #include <linux/vmalloc.h>
 #include <linux/delay.h>

Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

#1 lore raw
Quoted 2 lines · Antonino A. Daplas

Framebuffer drivers should have no dependencies on the tty layer.

<snip>

drivers/video/pnx4008/pnxrgbfb.c #include <linux/kernel.h> · line 23

Quoted 8 lines
drivers/video/pnx4008/pnxrgbfb.c +0 -1
@@ -18,7 +18,6 @@ #include <linux/kernel.h>
 #include <linux/errno.h>
 #include <linux/string.h>
 #include <linux/mm.h>
-#include <linux/tty.h>
 #include <linux/slab.h>
 #include <linux/vmalloc.h>
 #include <linux/delay.h>

Ok, agreed, thanks for pointing that out.

Vitaly

Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

#2 lore raw
Quoted 4 lines · Vitaly Wool
Quoted 2 lines · Antonino A. Daplas

Framebuffer drivers should have no dependencies on the tty layer.

<snip>

Quoted 10 lines

drivers/video/pnx4008/pnxrgbfb.c #include <linux/kernel.h> · line 23

Quoted 8 lines
drivers/video/pnx4008/pnxrgbfb.c +0 -1
@@ -18,7 +18,6 @@ #include <linux/kernel.h>
 #include <linux/errno.h>
 #include <linux/string.h>
 #include <linux/mm.h>
-#include <linux/tty.h>
 #include <linux/slab.h>
 #include <linux/vmalloc.h>
 #include <linux/delay.h>

Ok, agreed, thanks for pointing that out.

This actually depends on a just-recently submitted cleanup patch, removing dependencies on tty and vt. So #include <linux/tty.h> was the correct thing to do a few -mm versions ago :-)

Tony

Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642