Skip to contentSkip to conversation

drivers/char/mxser.c: check return value of

PATCH New Richard 1 participant 1 message Jul 4, 2006

Subsystems (3)
lore
Share & tools
lore

Richard

author
#0 lore raw

PATCH 1/1 drivers/char/mxser.c: check return value of

Signed-off-by Richard van Berkum <h.vanberkum at chello.nl>
drivers/char/mxser.c +11 -2
@@ -3127,8 +3139,17 @@ static int mxser_get_ISA_conf(int cap, s
 		hwconf->ports = 8;
 	else
 		hwconf->ports = 4;
-	request_region(hwconf->ioaddr[0], 8 * hwconf->ports, "mxser(IO)");
-	request_region(hwconf->vector, 1, "mxser(vector)");
+	if (!(request_region(hwconf->ioaddr[0], 8 * hwconf->ports, "mxser(IO)"))) {
+		printk(KERN_ERR "mxser: I/O ports already in use\n");
+		return -EIO;
+	}
+	
+	if (!(request_region(hwconf->vector, 1, "mxser(vector)"))) {
+		printk(KERN_ERR "mxser: I/O ports already in use\n");
+		release_region(hwconf->ioaddr[0], 8 * hwconf->ports);
+		return -EIO;
+	}
+				
 	return hwconf->ports;
 }
 

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors