Skip to contentSkip to conversation

ARM: OMAP: Fix missing channel using omap_set_dma_priority()

PATCH New Dirk Behme 1 participant 1 message Jul 4, 2006 Framebuffer layer

lore
Share & tools
lore

Dirk Behme

author
#0 lore raw

PATCH 1/1 ARM: OMAP: Fix missing channel using omap_set_dma_priority()

ARM: OMAP: Fix missing channel parameter using
omap_set_dma_priority() in omapfb_main.c:

drivers/video/omap/omapfb_main.c: In function 'omapfb_do_probe':
drivers/video/omap/omapfb_main.c:1441: error: too few arguments to function
'omap_set_dma_priority'

omap_set_dma_priority() in dma.c wants a channel as first parameter which is missing here. However, this is only used on OMAP24xx, on OMAP1 it isn't. Therefore I don't know if 0 is correct here, it's
don't care for OMAP1. Please check.

Signed-off-by Dirk Behme <dirk.behme_at_gmail.com>
drivers/video/omap/omapfb_main.c renamed from drivers/video/omap/omapfb_main.c_orig +1 -1
@@ -1438,7 +1438,7 @@ static int omapfb_do_probe(struct platfo
 #ifdef CONFIG_FB_OMAP_DMA_TUNE
 	/* Set DMA priority for EMIFF access to highest */
 	if (cpu_class_is_omap1())
-		omap_set_dma_priority(OMAP_DMA_PORT_EMIFF, 15);
+	        omap_set_dma_priority(0, OMAP_DMA_PORT_EMIFF, 15);
 #endif
 
 	r = ctrl_change_mode(fbdev->fb_info[0]);