Skip to contentSkip to conversation

Typo in cdrom.c also in linux-2.4

PATCH-2.4 Andreas Haumer 3 participants 3 messages Jul 6, 2006

lore
Share & tools
lore
#0 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Marcelo,
hi Willy,

are you aware of the discussion at
<http://bugzilla.kernel.org/show_bug.cgi?id=2966> ?

The typo seems to exist in linux-2.4 too, at least in 2.4.32, 2.4.32-hf32.6 and 2.4.33pre3 (which is what I checked today)

The fix for linux-2.4 would be just like the proposed patch for linux-2.6 (see attachment)

Comments?

- - andreas

- --

Andreas Haumer                     | mailto:[email protected]
*x Software + Systeme              | http://www.xss.co.at/
Karmarschgasse 51/2/20             | Tel: +43-1-6060114-0
A-1100 Vienna, Austria             | Fax: +43-1-6060114-71

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFErMhbxJmyeGcXPhERAgw6AKCwDRtEyE1EK+oT/nU5v2ysQxmWqACcDh1y eZq4acxsutVuP68nDDcEeAE=
=puYc
-----END PGP SIGNATURE-----

Index: cdrom.c
===================================================================
RCS file: /home/cvs/repository/distribution/Base/linux/drivers/cdrom/cdrom.c,v retrieving revision 1.1.1.10

cdrom.c +1 -1
diff -u -r1.1.1.10 cdrom.c
@@ -1259,7 +1259,7 @@
 	init_cdrom_command(&cgc, buf, sizeof(buf), CGC_DATA_READ);
 	cgc.cmd[0] = GPCMD_READ_DVD_STRUCTURE;
 	cgc.cmd[7] = s->type;
-	cgc.cmd[9] = cgc.buflen = 0xff;
+	cgc.cmd[9] = cgc.buflen & 0xff;
 
 	if ((ret = cdo->generic_packet(cdi, &cgc)))
 		return ret;
#1 lore raw

Hi Andreas,

Quoted 8 lines · Andreas Haumer

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Marcelo,
hi Willy,

are you aware of the discussion at
<http://bugzilla.kernel.org/show_bug.cgi?id=2966> ?

No, I was not aware. Scary !

Quoted 8 lines

The typo seems to exist in linux-2.4 too, at least in 2.4.32, 2.4.32-hf32.6 and 2.4.33pre3 (which is what I checked today)

The fix for linux-2.4 would be just like the proposed patch for linux-2.6 (see attachment)

Comments?

Looks fine and conform to Jens' description.
Queuing it into -upstream.

Quoted 1 line

- - andreas

Thanks,
Willy

Quoted 31 lines

- --

Andreas Haumer                     | mailto:[email protected]
*x Software + Systeme              | http://www.xss.co.at/
Karmarschgasse 51/2/20             | Tel: +43-1-6060114-0
A-1100 Vienna, Austria             | Fax: +43-1-6060114-71

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFErMhbxJmyeGcXPhERAgw6AKCwDRtEyE1EK+oT/nU5v2ysQxmWqACcDh1y eZq4acxsutVuP68nDDcEeAE=
=puYc
-----END PGP SIGNATURE-----

Index: cdrom.c
===================================================================
RCS file: /home/cvs/repository/distribution/Base/linux/drivers/cdrom/cdrom.c,v retrieving revision 1.1.1.10
diff -u -r1.1.1.10 cdrom.c

cdrom.c +1 -1
@@ -1259,7 +1259,7 @@
 	init_cdrom_command(&cgc, buf, sizeof(buf), CGC_DATA_READ);
 	cgc.cmd[0] = GPCMD_READ_DVD_STRUCTURE;
 	cgc.cmd[7] = s->type;
-	cgc.cmd[9] = cgc.buflen = 0xff;
+	cgc.cmd[9] = cgc.buflen & 0xff;
 
 	if ((ret = cdo->generic_packet(cdi, &cgc)))
 		return ret;