Skip to contentSkip to conversation

xfs fails dbench in 2.6.18-rc1-mm1

DISCUSSION Martin Bligh 5 participants 11 messages Jul 12, 2006 – Jul 13, 2006 XFS filesystem

lore
Share & tools
lore
#0 lore raw

http://test.kernel.org/abat/40891/debug/test.log.1

Filesystem type for /mnt/tmp is xfs write failed on handle 13786
4 clients started
Child failed with status 1 write failed on handle 13786 write failed on handle 13786 write failed on handle 13786

Works fine in -git4
All other fs's seemed to run OK.

Machine is a 4x Opteron.

#1 lore raw
Quoted 10 lines · Martin Bligh

http://test.kernel.org/abat/40891/debug/test.log.1

Filesystem type for /mnt/tmp is xfs write failed on handle 13786
4 clients started
Child failed with status 1 write failed on handle 13786 write failed on handle 13786 write failed on handle 13786

Quoted 4 lines

Works fine in -git4
All other fs's seemed to run OK.

Machine is a 4x Opteron.

You need to revert 92eb7a2f28d551acedeb5752263267a64b1f5ddf

http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blobdiff;h=3f356086061d7076a379b76e265295a5fe3750fe;hp=55f4e70225631b275f85215ee543b104507caacc;hb=92eb7a2f28d551acedeb5752263267a64b1f5ddf;f=fs/file.c

or change in alloc_fdtable()

nfds = max_t(int, 8 * L1_CACHE_BYTES, roundup_pow_of_two(nfds));

into

nfds = max_t(int, 8 * L1_CACHE_BYTES, roundup_pow_of_two(nr+1));

Eric

#2 lore raw
Quoted 11 lines · Eric Dumazet
Quoted 10 lines · Martin Bligh

http://test.kernel.org/abat/40891/debug/test.log.1

Filesystem type for /mnt/tmp is xfs write failed on handle 13786
4 clients started
Child failed with status 1 write failed on handle 13786 write failed on handle 13786 write failed on handle 13786

Quoted 6 lines
Quoted 4 lines

Works fine in -git4
All other fs's seemed to run OK.

Machine is a 4x Opteron.

You need to revert 92eb7a2f28d551acedeb5752263267a64b1f5ddf

Will give reverting that a spin.

-apw

#3 lore raw
In reply to Eric Dumazet
Quoted 12 lines · Eric Dumazet
Quoted 10 lines · Martin Bligh

http://test.kernel.org/abat/40891/debug/test.log.1

Filesystem type for /mnt/tmp is xfs write failed on handle 13786
4 clients started
Child failed with status 1 write failed on handle 13786 write failed on handle 13786 write failed on handle 13786

Quoted 7 lines
Quoted 4 lines

Works fine in -git4
All other fs's seemed to run OK.

Machine is a 4x Opteron.

You need to revert 92eb7a2f28d551acedeb5752263267a64b1f5ddf

Still fails (thanks Andy).

M.

#4 lore raw
Quoted 16 lines · Martin Bligh
Quoted 15 lines · Eric Dumazet
Quoted 13 lines · Martin Bligh

http://test.kernel.org/abat/40891/debug/test.log.1

Filesystem type for /mnt/tmp is xfs write failed on handle 13786
4 clients started
Child failed with status 1 write failed on handle 13786 write failed on handle 13786 write failed on handle 13786

Works fine in -git4
All other fs's seemed to run OK.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Machine is a 4x Opteron.

You need to revert 92eb7a2f28d551acedeb5752263267a64b1f5ddf

Still fails (thanks Andy).

Wondering if its my changes :(
Can you back out these and try ?

Please, Please tell me that, its not me :)

Thanks,
Badari

#
vectorize-aio_read-aio_write-fileop-methods.patch remove-readv-writev-methods-and-use-aio_read-aio_write.patch streamline-generic_file_-interfaces-and-filemap.patch streamline-generic_file_-interfaces-and-filemap-ecryptfs.patch

#5 lore raw
Quoted 33 lines · Badari Pulavarty
Quoted 17 lines · Martin Bligh
Quoted 15 lines · Eric Dumazet
Quoted 13 lines · Martin Bligh

http://test.kernel.org/abat/40891/debug/test.log.1

Filesystem type for /mnt/tmp is xfs write failed on handle 13786
4 clients started
Child failed with status 1 write failed on handle 13786 write failed on handle 13786 write failed on handle 13786

Works fine in -git4
All other fs's seemed to run OK.

Quoted 9 lines
Quoted 5 lines
Quoted 1 line

Machine is a 4x Opteron.

You need to revert 92eb7a2f28d551acedeb5752263267a64b1f5ddf

Still fails (thanks Andy).

Wondering if its my changes :(
Can you back out these and try ?

Please, Please tell me that, its not me :)

Quoted 8 lines

Thanks,
Badari

#
vectorize-aio_read-aio_write-fileop-methods.patch remove-readv-writev-methods-and-use-aio_read-aio_write.patch streamline-generic_file_-interfaces-and-filemap.patch streamline-generic_file_-interfaces-and-filemap-ecryptfs.patch

You could submit a job to elm3b6 to run dbench on xfs ;-)

M.

#6 lore raw
Quoted 43 lines · Martin Bligh
Quoted 33 lines · Badari Pulavarty
Quoted 17 lines · Martin Bligh
Quoted 15 lines · Eric Dumazet
Quoted 13 lines · Martin Bligh

http://test.kernel.org/abat/40891/debug/test.log.1

Filesystem type for /mnt/tmp is xfs write failed on handle 13786
4 clients started
Child failed with status 1 write failed on handle 13786 write failed on handle 13786 write failed on handle 13786

Works fine in -git4
All other fs's seemed to run OK.

Quoted 9 lines
Quoted 5 lines
Quoted 1 line

Machine is a 4x Opteron.

You need to revert 92eb7a2f28d551acedeb5752263267a64b1f5ddf

Still fails (thanks Andy).

Wondering if its my changes :(
Can you back out these and try ?

Please, Please tell me that, its not me :)

Quoted 8 lines

Thanks,
Badari

#
vectorize-aio_read-aio_write-fileop-methods.patch remove-readv-writev-methods-and-use-aio_read-aio_write.patch streamline-generic_file_-interfaces-and-filemap.patch streamline-generic_file_-interfaces-and-filemap-ecryptfs.patch

Quoted 3 lines

You could submit a job to elm3b6 to run dbench on xfs ;-)

M.

I am not able to "insmod xfs.ko" on my x86-64 machine :(

elm3b29:~ # modprobe xfs
FATAL: Error inserting xfs (/lib/modules/2.6.18-rc1- mm1/kernel/fs/xfs/xfs.ko): Cannot allocate memory

#dmesg shows ..

Could not allocate 8 bytes percpu data Could not allocate 8 bytes percpu data Could not allocate 8 bytes percpu data Could not allocate 8 bytes percpu data Could not allocate 8 bytes percpu data Could not allocate 8 bytes percpu data Could not allocate 328 bytes percpu data Could not allocate 328 bytes percpu data Could not allocate 328 bytes percpu data

Whats happening here ?

Thanks,
Badari

#7 lore raw
Quoted 19 lines

I am not able to "insmod xfs.ko" on my x86-64 machine :(

elm3b29:~ # modprobe xfs
FATAL: Error inserting xfs (/lib/modules/2.6.18-rc1- mm1/kernel/fs/xfs/xfs.ko): Cannot allocate memory

#dmesg shows ..

Could not allocate 8 bytes percpu data Could not allocate 8 bytes percpu data Could not allocate 8 bytes percpu data Could not allocate 8 bytes percpu data Could not allocate 8 bytes percpu data Could not allocate 8 bytes percpu data Could not allocate 328 bytes percpu data Could not allocate 328 bytes percpu data Could not allocate 328 bytes percpu data

Quoted 1 line

Whats happening here ?

Dunno, but I built it statically, and didn't have that problem ;-) The default config on elm3b6 should work.
http://ftp.kernel.org/pub/linux/kernel/people/mbligh/config/abat/amd64

#8 lore raw
In reply to Badari Pulavarty
Quoted 68 lines · Badari Pulavarty
Quoted 43 lines · Martin Bligh
Quoted 33 lines · Badari Pulavarty
Quoted 17 lines · Martin Bligh
Quoted 15 lines · Eric Dumazet
Quoted 13 lines · Martin Bligh

http://test.kernel.org/abat/40891/debug/test.log.1

Filesystem type for /mnt/tmp is xfs write failed on handle 13786
4 clients started
Child failed with status 1 write failed on handle 13786 write failed on handle 13786 write failed on handle 13786

Works fine in -git4
All other fs's seemed to run OK.

Quoted 9 lines
Quoted 5 lines
Quoted 1 line

Machine is a 4x Opteron.

You need to revert 92eb7a2f28d551acedeb5752263267a64b1f5ddf

Still fails (thanks Andy).

Wondering if its my changes :(
Can you back out these and try ?

Please, Please tell me that, its not me :)

Quoted 8 lines

Thanks,
Badari

#
vectorize-aio_read-aio_write-fileop-methods.patch remove-readv-writev-methods-and-use-aio_read-aio_write.patch streamline-generic_file_-interfaces-and-filemap.patch streamline-generic_file_-interfaces-and-filemap-ecryptfs.patch

Quoted 3 lines

You could submit a job to elm3b6 to run dbench on xfs ;-)

M.

I am not able to "insmod xfs.ko" on my x86-64 machine :(

elm3b29:~ # modprobe xfs
FATAL: Error inserting xfs (/lib/modules/2.6.18-rc1- mm1/kernel/fs/xfs/xfs.ko): Cannot allocate memory

#dmesg shows ..

Could not allocate 8 bytes percpu data Could not allocate 8 bytes percpu data Could not allocate 8 bytes percpu data Could not allocate 8 bytes percpu data Could not allocate 8 bytes percpu data Could not allocate 8 bytes percpu data Could not allocate 328 bytes percpu data Could not allocate 328 bytes percpu data Could not allocate 328 bytes percpu data

Quoted 1 line

Whats happening here ?

The per-cpu area is exhausted in -mm x68_64 (If you pump up the percpu area or cut down NR_CPUS you can work around it). I ran into this a few -mm release ago. There are some details in the 2.6.17-mm6 thread from July 5th of so.

Thanks,
Keith

#9 lore raw
In reply to Martin Bligh
Quoted 17 lines · Martin Bligh
Quoted 16 lines · Badari Pulavarty
Quoted 14 lines · Martin Bligh
Quoted 12 lines · Eric Dumazet
Quoted 10 lines · Martin Bligh

http://test.kernel.org/abat/40891/debug/test.log.1

Filesystem type for /mnt/tmp is xfs write failed on handle 13786
4 clients started
Child failed with status 1 write failed on handle 13786 write failed on handle 13786 write failed on handle 13786

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

Works fine in -git4
All other fs's seemed to run OK.

Machine is a 4x Opteron.

Sorry !! its my screw up again :(
Here is the patch to fix it.

Thanks,
Badari

Fix a bug in __xfs_file_write() which is causing writes to fail with -EINVAL.

fs/xfs/linux-2.6/xfs_file.c +1 -1
Index: linux-2.6.18-rc1/fs/xfs/linux-2.6/xfs_file.c
===================================================================
@@ -99,7 +99,7 @@ __xfs_file_write(
 	BUG_ON(iocb->ki_pos != pos);
 	if (unlikely(file->f_flags & O_DIRECT))
 		ioflags |= IO_ISDIRECT;
-	return bhv_vop_write(vp, iocb, &iov, nr_segs, &iocb->ki_pos,
+	return bhv_vop_write(vp, iocb, iov, nr_segs, &iocb->ki_pos,
 				ioflags, NULL);
 }
 
#10 lore raw
Quoted 26 lines · Badari Pulavarty
Quoted 17 lines · Martin Bligh
Quoted 16 lines · Badari Pulavarty
Quoted 14 lines · Martin Bligh
Quoted 12 lines · Eric Dumazet
Quoted 10 lines · Martin Bligh

http://test.kernel.org/abat/40891/debug/test.log.1

Filesystem type for /mnt/tmp is xfs write failed on handle 13786
4 clients started
Child failed with status 1 write failed on handle 13786 write failed on handle 13786 write failed on handle 13786

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

Works fine in -git4
All other fs's seemed to run OK.

Machine is a 4x Opteron.

Sorry !! its my screw up again :(
Here is the patch to fix it.

Quoted 7 lines

Thanks,
Badari

Fix a bug in __xfs_file_write() which is causing writes to fail with -EINVAL.

Ok, I've thrown this one + apkm's latest fix into the tester. Only one result in so far, but that is our first good on that machine.

-apw