gpio: drop gpio_set_high/low from vtable, and from pc8736x_gpio
Subsystems (3)
Jim Cromie
maintainerPATCH v2 1/3 gpio: drop gpio_set_high/low from vtable, and from pc8736x_gpio
1 - drops gpio_set_high, gpio_set_low from the nsc_gpio_ops vtable. While we can't drop them from scx200_gpio (or can we?), we dont need them for new users of the exported vtable; gpio_set(1), gpio_set(0) work fine. v2 also deletes those functions from pc8736x_gpio, fixing the unused warnings. scx200_gpio doesnt need this, its functions are defined in the header file.
Signed-off-by Jim Cromie <[email protected]>
---
$ diffstat fxd3/diff.nosethilo-2 drivers/char/pc8736x_gpio.c | 12 ------------ drivers/char/scx200_gpio.c | 2 -- include/linux/nsc_gpio.h | 2 -- 3 files changed, 16 deletions(-)
drivers/char/pc8736x_gpio.c +0 -0
@@ -188,16 +188,6 @@ static void pc8736x_gpio_set(unsigned mi
pc8736x_gpio_shadow[port] = val; }
-static void pc8736x_gpio_set_high(unsigned index) -{
- pc8736x_gpio_set(index, 1);
-}
-
-static void pc8736x_gpio_set_low(unsigned index) -{
- pc8736x_gpio_set(index, 0);
-}
-
static int pc8736x_gpio_current(unsigned minor)
{
int port, bit;
@@ -218,8 +208,6 @@ static struct nsc_gpio_ops pc8736x_acces
.gpio_dump = nsc_gpio_dump,
.gpio_get = pc8736x_gpio_get,
.gpio_set = pc8736x_gpio_set,
- .gpio_set_high = pc8736x_gpio_set_high,
- .gpio_set_low = pc8736x_gpio_set_low,
.gpio_change = pc8736x_gpio_change,
.gpio_current = pc8736x_gpio_current
};drivers/char/scx200_gpio.c +0 -0
@@ -41,8 +41,6 @@ struct nsc_gpio_ops scx200_access = {
.gpio_dump = nsc_gpio_dump, .gpio_get = scx200_gpio_get, .gpio_set = scx200_gpio_set, - .gpio_set_high = scx200_gpio_set_high, - .gpio_set_low = scx200_gpio_set_low, .gpio_change = scx200_gpio_change, .gpio_current = scx200_gpio_current };
include/linux/nsc_gpio.h +0 -0
@@ -25,8 +25,6 @@ struct nsc_gpio_ops {
void (*gpio_dump) (struct nsc_gpio_ops *amp, unsigned iminor); int (*gpio_get) (unsigned iminor); void (*gpio_set) (unsigned iminor, int state); - void (*gpio_set_high)(unsigned iminor); - void (*gpio_set_low) (unsigned iminor); void (*gpio_change) (unsigned iminor); int (*gpio_current) (unsigned iminor); struct device* dev; /* for dev_dbg() support, set in init */