Skip to contentSkip to conversation

HVM SMBIOS v2 0/5

PATCH In review Andrew D. Ball 2 participants 2 messages Jul 12, 2006 – Aug 4, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 HVM SMBIOS v2 0/5

The following patches are a cleaned up version of the HVM SMBIOS patches I submitted last Friday.

I apologize if these are posted twice -- the first time I tried to send them I didn't see them show up after 40 minutes...

Differences include

(1) SMBIOS is no longer optional for HVM domU's.
(2) The refactoring I did of hvmloader wasn't really necessary, so I got rid of it.
(3) The patches have been tested on changeset

10671:b20580cf7fc1bfe5119597bb5b576cdd020551d5

(4) The versions of strcpy() and strncpy() I wrote in util.c now behave properly: strncpy() pads the destination string with NULs until its size limit is reached and both strcpy() and strncpy() return the address of the destination string.

Peace.
Andrew

#1 lore raw
Quoted 5 lines · Andrew D. Ball

The following patches are a cleaned up version of the HVM SMBIOS patches I submitted last Friday.

I apologize if these are posted twice -- the first time I tried to send them I didn't see them show up after 40 minutes...

These patches need rebasing to changeset 10948 or after. The changes I made there should make your patchset rather smaller!

The main thing is to get rid of your additions to hvm_info_table:
1. Uuid can be got via hypercall_xen_version(XENVER_guest_handle)
2. Version info can be got via other XENVER_ commands
3. Memsize can roughly be worked out from the e820 table

I see you add a util.c -- I actually also made the same cleanup in my changeset although I think you add another couple of functions.

Hopefully the way to use the hypercalls is obvious from the above changeset. I added a simple example to hvmloader.c:init_hypercalls() to print version information.

Thanks,
Keir