Skip to contentSkip to conversation

e1000: add forgotten PCI ID for supported device

PATCH Applied Auke Kok 4 participants 6 messages Jul 28, 2006 – Aug 3, 2006

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Auke Kok

author
#0 lore raw

PATCH 1/1 e1000: add forgotten PCI ID for supported device

The Intel(R) PRO/1000 82572EI card is fully supported by 7.0.33-k2 and onward. Add the device ID so this card works with 2.6.17.y onward. This device ID was accidentally omitted.

Signed-off-by Auke Kok <[email protected]>
drivers/net/e1000/e1000_hw.c +1 -0
index 523c2c9..c5e7023 100644
@@ -353,6 +353,7 @@ e1000_set_mac_type(struct e1000_hw *hw)
     case E1000_DEV_ID_82572EI_COPPER:
     case E1000_DEV_ID_82572EI_FIBER:
     case E1000_DEV_ID_82572EI_SERDES:
+    case E1000_DEV_ID_82572EI:
         hw->mac_type = e1000_82572;
         break;
     case E1000_DEV_ID_82573E:
drivers/net/e1000/e1000_hw.h +1 -0
index 150e45e..c01e5d2 100644
@@ -462,6 +462,7 @@ #define E1000_DEV_ID_82571EB_SERDES     
 #define E1000_DEV_ID_82572EI_COPPER      0x107D
 #define E1000_DEV_ID_82572EI_FIBER       0x107E
 #define E1000_DEV_ID_82572EI_SERDES      0x107F
+#define E1000_DEV_ID_82572EI             0x10B9
 #define E1000_DEV_ID_82573E              0x108B
 #define E1000_DEV_ID_82573E_IAMT         0x108C
 #define E1000_DEV_ID_82573L              0x109A
#1 lore raw
Quoted 4 lines · Auke Kok

The Intel(R) PRO/1000 82572EI card is fully supported by 7.0.33-k2 and onward. Add the device ID so this card works with 2.6.17.y onward. This device ID was accidentally omitted.

Sorry, but we don't add new device support in the -stable kernel tree, it's "bugfixes only."

thanks,

greg k-h

#2 lore raw
Quoted 8 lines · Greg KH
Quoted 4 lines · Auke Kok

The Intel(R) PRO/1000 82572EI card is fully supported by 7.0.33-k2 and onward. Add the device ID so this card works with 2.6.17.y onward. This device ID was accidentally omitted.

Sorry, but we don't add new device support in the -stable kernel tree, it's "bugfixes only."

In this case I believe it to be a bug in our code, instead of adding new support. The driver code supports other device IDs for this same chip.

The kernel driver advertises through our probe table and in our readme that we support this device (code is in e1000_main.c) but we don't load on it correctly due to an error when we submitted the patches (e1000_hw.c/h).

Patch is very simple and low risk, but it is your call.

Thanks,
Jesse

#3 lore raw
Quoted 7 lines · Jesse
Quoted 6 lines · Greg KH
Quoted 4 lines · Auke Kok

The Intel(R) PRO/1000 82572EI card is fully supported by 7.0.33-k2 and onward. Add the device ID so this card works with 2.6.17.y onward. This device ID was accidentally omitted.

Quoted 5 lines
Quoted 2 lines

Sorry, but we don't add new device support in the -stable kernel tree, it's "bugfixes only."

In this case I believe it to be a bug in our code, instead of adding new support. The driver code supports other device IDs for this same chip.

Heh, that would be a slipery slope, as everyone who adds device ids feels that it is a "bug" that the driver does not support their device. If we were to allow this, there would be a _lot_ more -stable patches, which I don't think is a good thing to have.

Quoted 5 lines

The kernel driver advertises through our probe table and in our readme that we support this device (code is in e1000_main.c) but we don't load on it correctly due to an error when we submitted the patches (e1000_hw.c/h).

Patch is very simple and low risk, but it is your call.

Sorry, but for now, no. Users should be able to use the sysfs bind and new_id interface to add new device support for your driver, if it's written properly :)

thanks,

greg k-h

#4 lore raw
Quoted 11 lines · Greg KH
Quoted 5 lines · Jesse

The kernel driver advertises through our probe table and in our readme that we support this device (code is in e1000_main.c) but we don't load on it correctly due to an error when we submitted the patches (e1000_hw.c/h).

Patch is very simple and low risk, but it is your call.

Sorry, but for now, no. Users should be able to use the sysfs bind and new_id interface to add new device support for your driver, if it's written properly :)

In this case it isn't an addition to the PCI ID table, but an actual added check in the code. You could make the argument that it is a bug since the PCI ID table says the device is supported, but it won't work w/o this additional check.

Of course, the "if it's written properly" comment is still valid... :-)

John

Signature · 2 lines
John W. Linville
[email protected]
Applied
#5 lore raw
Quoted 9 lines · John W. Linville
Quoted 8 lines · Greg KH
Quoted 5 lines · Jesse

The kernel driver advertises through our probe table and in our readme that we support this device (code is in e1000_main.c) but we don't load on it correctly due to an error when we submitted the patches (e1000_hw.c/h).

Patch is very simple and low risk, but it is your call.

Quoted 8 lines
Quoted 3 lines

Sorry, but for now, no. Users should be able to use the sysfs bind and new_id interface to add new device support for your driver, if it's written properly :)

In this case it isn't an addition to the PCI ID table, but an actual added check in the code. You could make the argument that it is a bug since the PCI ID table says the device is supported, but it won't work w/o this additional check.

Ok, fine, you all convinced me :)

Queued to -stable.

thanks,

greg k-h