Skip to contentSkip to conversation

rivafb: use constants instead of magic values

PATCH In review Antonino A. Daplas 1 participant 1 message Jul 31, 2006 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 6/13 rivafb: use constants instead of magic values

From: Guido Guenther <[email protected]>

use (MIN/MAX)_LEVEL and FB_(UN)BLANK instead of the values they are defined to

---

 drivers/video/riva/fbdev.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
drivers/video/riva/fbdev.c +4 -4
index 76fc9d3..43aa8be 100644
@@ -389,8 +389,8 @@ #endif
 	mutex_lock(&info->bl_mutex);
 	info->bl_dev = bd;
 	fb_bl_default_curve(info, 0,
-		0x158 * FB_BACKLIGHT_MAX / MAX_LEVEL,
-		0x534 * FB_BACKLIGHT_MAX / MAX_LEVEL);
+		MIN_LEVEL * FB_BACKLIGHT_MAX / MAX_LEVEL,
+		FB_BACKLIGHT_MAX);
 	mutex_unlock(&info->bl_mutex);
 
 	up(&bd->sem);
@@ -780,7 +780,7 @@ static void riva_load_video_mode(struct 
 	
 	NVTRACE_ENTER();
 	/* time to calculate */
-	rivafb_blank(1, info);
+	rivafb_blank(FB_BLANK_NORMAL, info);
 
 	bpp = info->var.bits_per_pixel;
 	if (bpp == 16 && info->var.green.length == 5)
@@ -913,7 +913,7 @@ static void riva_load_video_mode(struct 
 	par->current_state = newmode;
 	riva_load_state(par, &par->current_state);
 	par->riva.LockUnlock(&par->riva, 0); /* important for HW cursor */
-	rivafb_blank(0, info);
+	rivafb_blank(FB_BLANK_UNBLANK, info);
 	NVTRACE_LEAVE();
 }
 

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV