Skip to contentSkip to conversation

matroxfb: Honor the return value of pci_register_driver

PATCH In review Antonino A. Daplas 1 participant 1 message Aug 10, 2006 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 6/8 matroxfb: Honor the return value of pci_register_driver

Check the return value of pci_register_driver()

---

 drivers/video/matrox/matroxfb_base.c |   12 ++++++++----
 1 files changed, 8 insertions(+), 4 deletions(-)
drivers/video/matrox/matroxfb_base.c +8 -4
index 4a57dab..7acf01c 100644
@@ -2277,10 +2277,13 @@ static void __init matroxfb_init_params(
 	}
 }
 
-static void __init matrox_init(void) {
+static int __init matrox_init(void) {
+	int err;
+
 	matroxfb_init_params();
-	pci_register_driver(&matroxfb_driver);
+	err = pci_register_driver(&matroxfb_driver);
 	dev = -1;	/* accept all new devices... */
+	return err;
 }
 
 /* **************************** exit-time only **************************** */
@@ -2437,6 +2440,7 @@ static int __initdata initialized = 0;
 static int __init matroxfb_init(void)
 {
 	char *option = NULL;
+	int err = 0;
 
 	DBG(__FUNCTION__)
 
@@ -2448,11 +2452,11 @@ static int __init matroxfb_init(void)
 		return -ENXIO;
 	if (!initialized) {
 		initialized = 1;
-		matrox_init();
+		err = matrox_init();
 	}
 	hotplug = 1;
 	/* never return failure, user can hotplug matrox later... */
-	return 0;
+	return err;
 }
 
 module_init(matroxfb_init);

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642