Skip to contentSkip to conversation

i810fb: Honor the return value of pci_enable_device

PATCH In review Antonino A. Daplas 1 participant 1 message Aug 10, 2006 Framebuffer layer

lore
Share & tools
lore

Antonino A. Daplas

author
#0 lore raw

PATCH 8/8 i810fb: Honor the return value of pci_enable_device

Check the return value of pci_enable_device().

Signed-off-by Antonino Daplas <[email protected]>

---

 drivers/video/i810/i810_main.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
drivers/video/i810/i810_main.c +5 -1
index d42edac..b55a12d 100644
@@ -1602,7 +1602,10 @@ static int i810fb_resume(struct pci_dev 
 	acquire_console_sem();
 	pci_set_power_state(dev, PCI_D0);
 	pci_restore_state(dev);
-	pci_enable_device(dev);
+
+	if (pci_enable_device(dev))
+		goto fail;
+
 	pci_set_master(dev);
 	agp_bind_memory(par->i810_gtt.i810_fb_memory,
 			par->fb.offset);

@@ -1611,6 +1614,7 @@ static int i810fb_resume(struct pci_dev 
 	i810fb_set_par(info);
 	fb_set_suspend (info, 0);
 	info->fbops->fb_blank(VESA_NO_BLANKING, info);
+fail:
 	release_console_sem();
 	return 0;
 }

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642