Skip to contentSkip to conversation

i386: move kernel_thread_helper into entry.S

PATCH Jan Beulich 2 participants 2 messages Aug 14, 2006

lore
Share & tools
lore
#0 lore raw
Quoted 7 lines
Quoted 3 lines

And this too - the value now in %eax has no relation with the value known by the caller of this routine (which doesn't expect any return from here anyway).

Ok, but somehow it needs to be annotiated so that the unwinder stops and doesn't fall back. Can you please send a replacement patch that does this correctly?

Actually, with the previous attempt we still didn't achieve the original
goal of terminating the frame chain at kernel_thread_helper. Thus another try (the seemingly odd extra push can be avoided once we start using CFI expressions, which the unwinder currently doesn't support):

ENTRY(kernel_thread_helper)
CFI_STARTPROC
pushl $0 # fake return address
movl %edx,%eax
pushl %edx
CFI_ADJUST_CFA_OFFSET 4
call *%ebx
pushl %eax
CFI_ADJUST_CFA_OFFSET 4
call do_exit
CFI_ENDPROC
ENDPROC(kernel_thread_helper)

Jan

#1 lore raw
Quoted 8 lines · Jan Beulich
Quoted 7 lines
Quoted 3 lines

And this too - the value now in %eax has no relation with the value known by the caller of this routine (which doesn't expect any return from here anyway).

Ok, but somehow it needs to be annotiated so that the unwinder stops and doesn't fall back. Can you please send a replacement patch that does this correctly?

Quoted 6 lines

Actually, with the previous attempt we still didn't achieve the original
goal of terminating the frame chain at kernel_thread_helper. Thus another try (the seemingly odd extra push can be avoided once we start using CFI expressions, which the unwinder currently doesn't support):

I added the extra push thanks (hope there weren't more changes)

-Andi