Skip to contentSkip to conversation

PATCH/FIX for drivers/cdrom/cdrom.c

PATCH NAK Dirk 7 participants 10 messages Aug 16, 2006 – Aug 17, 2006

lore
Share & tools
lore

Dirk

author
#0 lore raw

I have changed a message that didn't clearly tell the user what was goin on...

Please have a look!

Thank you,
Dirk

cdrom/cdrom.c renamed from cdrom/cdrom.c.old +1 -1
@@ -2455,7 +2455,7 @@
 		if (tracks.data > 0) return CDS_DATA_1;
 		/* Policy mode off */
 
-		cdinfo(CD_WARNING,"This disc doesn't have any tracks I recognize!\n");
+		cdinfo(CD_WARNING,"I'm a stupid fuck that will repeat this interesting message while endlessly trying to access the media you just inserted until your CD/DVD burning task is eventually fucked\n");
 		return CDS_NO_INFO;
 		}
 
#1 lore raw
Quoted 5 lines

I have changed a message that didn't clearly tell the user what was goin on...

Please have a look!

It is not April 01, is it?

Jan Engelhardt

author
#2 lore raw
Quoted 10 lines · Jan Engelhardt
Quoted 4 lines

I have changed a message that didn't clearly tell the user what was goin on...

Please have a look!

It is not April 01, is it?

Jan Engelhardt

Only when I try to burn a CD...

#3 lore raw
In reply to Dirk
Quoted 4 lines · Dirk

I have changed a message that didn't clearly tell the user what was goin on...

Please have a look!

Perhaps the real problem is that some @#$@#$ user space task is constantly trying to mount the disc while something else is trying to write to it.

gnome and kde both seem very eager to implement such things. perhaps there should be a way to prevent any access by such processes while writing to the disc.

--
Len Sorensen

#4 lore raw
Quoted 6 lines · Lennart Sorensen
Quoted 4 lines · Dirk

I have changed a message that didn't clearly tell the user what was goin on...

Please have a look!

Quoted 7 lines

Perhaps the real problem is that some @#$@#$ user space task is constantly trying to mount the disc while something else is trying to write to it.

gnome and kde both seem very eager to implement such things. perhaps there should be a way to prevent any access by such processes while writing to the disc.

there is. O_EXCL works for this.
Any sane desktop app and cd burning app use O_EXCL already for this purpose...

#6 lore raw
In reply to Dirk

Ar Mer, 2006-08-16 am 19:26 +0200, ysgrifennodd Dirk:

Quoted 2 lines

I have changed a message that didn't clearly tell the user what was goin on...

File a gnome/kde/distro bug according whichever pile of garbage you've got trying to do CD status monitoring and getting it wrong. This isn't a kernel problem, some idiot user application is asking it continually.

Now there is an argument that the message is debug only but thats another story.

Alan

author
#5 lore raw
In reply to Lennart Sorensen
Quoted 12 lines · Lennart Sorensen
Quoted 4 lines · Dirk

I have changed a message that didn't clearly tell the user what was goin on...

Please have a look!

Perhaps the real problem is that some @#$@#$ user space task is constantly trying to mount the disc while something else is trying to write to it.

Quoted 8 lines

gnome and kde both seem very eager to implement such things. perhaps there should be a way to prevent any access by such processes while writing to the disc.

--
Len Sorensen

I still use fvwm1 with _my_ config file unchanged for ~6 years now!!!

But you were right... after i removed some package called "hal" everything works fine again...

must have been another trojan from the "Ready for the Desktop!" camp...

Dirk

#7 lore raw
In reply to Dirk
Quoted 12 lines · On Wed, 16 Aug 2006 19:26:02 +0200 Dirk <[email protected]> wrote:

I have changed a message that didn't clearly tell the user what was goin on...

Please have a look!

Thank you,
Dirk

cdrom/cdrom.c line 2460

Quoted 7 lines
cdrom/cdrom.c renamed from cdrom/cdrom.c.old +1 -1
@@ -2455,7 +2455,7 @@
 		if (tracks.data > 0) return CDS_DATA_1;
 		/* Policy mode off */
 
-		cdinfo(CD_WARNING,"This disc doesn't have any tracks I recognize!\n");
+		cdinfo(CD_WARNING,"I'm a stupid fuck that will repeat this interesting message while endlessly trying to access the media you just inserted until your CD/DVD burning task is eventually fucked\n");
 		return CDS_NO_INFO;
 		}

Please keep the code formatted to fit in an 80-column xterm. See Documentation/CodingStyle. Thanks.

(And you forget the Signed-off-by: line)

#8 lore raw
Quoted 23 lines
Quoted 12 lines

I have changed a message that didn't clearly tell the user what was goin on...

Please have a look!

Thank you,
Dirk

cdrom/cdrom.c line 2460

Quoted 7 lines
cdrom/cdrom.c renamed from cdrom/cdrom.c.old +1 -1
@@ -2455,7 +2455,7 @@
 		if (tracks.data > 0) return CDS_DATA_1;
 		/* Policy mode off */
 
-		cdinfo(CD_WARNING,"This disc doesn't have any tracks I recognize!\n");
+		cdinfo(CD_WARNING,"I'm a stupid fuck that will repeat this interesting message while endlessly trying to access the media you just inserted until your CD/DVD burning task is eventually fucked\n");
 		return CDS_NO_INFO;
 		}

Please keep the code formatted to fit in an 80-column xterm. See Documentation/CodingStyle. Thanks.

Quoted 1 line

(And you forget the Signed-off-by: line)

Before any of this gets ANY chance to get in:

NAK.

Jan Engelhardt

#9 lore raw

YMMD (Was: Re: PATCH/FIX for drivers/cdrom/cdrom.c)

In reply to Andrew Morton
Quoted 4 lines · Andrew Morton

Please keep the code formatted to fit in an 80-column xterm. See Documentation/CodingStyle. Thanks.

(And you forget the Signed-off-by: line)

You made my day :..D