generic_file_llseek vs. remote_llseek
Now that generic_file_llseek locks the inode, do we need to have anyone use remote_llseek?
Although remote_llseek is newer, it does a lock_kernel which seems excessive, unless it has to do with some isize_write race issue it is trying to avoid.
The cifs code would probably be fine with the change to the (presumably faster) generic_file_llseek, and perhas the nfs code as weel..
Quoted 10 lines · Steve French (smfltc)
Now that
generic_file_llseeklocks the inode, do we need to have anyone useremote_llseek?Although
remote_llseekis newer, it does alock_kernelwhich seems excessive, unless it has to do with
someisize_writerace issue it is trying to avoid.The cifs code would probably be fine with the change to the (presumably faster)
generic_file_llseek,
and perhas the nfs code as weel..
NFS has issues with isize_write(). We can't use it 'cos it presupposes that all size changes will occur under the inode->i_mutex. Unfortunately, remote servers don't take our local inode->i_mutex.
Cheers,
Trond