PowerOP, Whatchanged/Issues/TODO 2/2
whatchanged:
- optional sysfs interface is added
- code is moved under kernel/power
- Greg's comments on kobject and coding style are addressed
todo/issues:
- better implementation for getting registered operating point names
- move string parsing into powerop generic code
- configfs for operating points creation from user space
Quoted 9 lines · Eugeny S. Mints
whatchanged:
- optional sysfs interface is added
- code is moved under kernel/power
- Greg's comments on kobject and coding style are addressedtodo/issues:
- better implementation for getting registered operating point names
- move string parsing into powerop generic code
- configfs for operating points creation from user space
You forgot:
- Handle module referencing counting issues.
Also, no #ifdefs in the .c code please, that debugging stuff doesn't have to look like that, break it out into separate functions to keep the codepath clean.
thanks,
greg k-h
Greg,
Quoted 6 lines · Greg KH
Quoted 5 lines · Eugeny S. Mints
whatchanged:
- optional sysfs interface is added
- code is moved under kernel/power
- Greg's comments on kobject and coding style are addressed
Quoted 7 lines
Quoted 4 lines
todo/issues:
- better implementation for getting registered operating point names
- move string parsing into powerop generic code
- configfs for operating points creation from user spaceYou forgot:
- Handle module referencing counting issues.
i'm discussing this and other issues you pointed out in a separate email.
Quoted 3 lines
Also, no #ifdefs in the .c code please, that debugging stuff doesn't have to look like that,
do you mean CONFIG_POWEROP_SYSFS_OP_DEBUG_IF? Probably it's not a good name but it's not a debugging code. it could be CONFIG_POWEROP_SYSFS_OP_HW_IF - this special HW point might be useful in a production code.
Eugeny
Quoted 7 lines
break it out into separate functions to keep the
codepath clean.thanks,
greg k-h
Quoted 16 lines · Eugeny S. Mints
Greg,
Quoted 6 lines · Greg KH
Quoted 5 lines · Eugeny S. Mints
whatchanged:
- optional sysfs interface is added
- code is moved under kernel/power
- Greg's comments on kobject and coding style are addressedQuoted 7 lines
Quoted 4 lines
todo/issues:
- better implementation for getting registered operating point names
- move string parsing into powerop generic code
- configfs for operating points creation from user spaceYou forgot:
- Handle module referencing counting issues.
Quoted 7 lines
i'm discussing this and other issues you pointed out in a separate email.
Quoted 3 lines
Also, no #ifdefs in the .c code please, that debugging stuff doesn't have to look like that,
do you mean
CONFIG_POWEROP_SYSFS_OP_DEBUG_IF? Probably it's not a good name but it's not a debugging code. it could beCONFIG_POWEROP_SYSFS_OP_HW_IF- this special HW point might be useful in a production code.
No matter what the name, the #ifdef does not belong in the .c code in the manner like this was done. Please move it.
thanks,
greg k-h
Hi!
Quoted 8 lines
whatchanged:
- optional sysfs interface is added
- code is moved under kernel/power
- Greg's comments on kobject and coding style are addressedtodo/issues:
- better implementation for getting registered operating point names
- move string parsing into powerop generic code
Can we get rid of string parsing altogether? It should be possible to design better in-kernel interface than char *. Can you just use opaque structure?
Signature · 1 line
Thanks for all the (sleeping) penguins.