remove dead code from bcm43xx-softmac
Subsystems (3)
PATCH 1/1 remove dead code from bcm43xx-softmac
John,
Please queue the following patch for wireless-2.6. It removes some code that was made obsolete by the wireless statistics changes of several weeks ago, but was not noticed them.
Thanks,
Larry
=================
This patch removes code that was make obsolete when the wireless statistics in bcm43xx-softmac were changed, but was overlooked at that time. The value of bcm->stats.link_quality computed here is never used.
drivers/net/wireless/bcm43xx/bcm43xx_main.c +1 -11
@@ -1549,17 +1549,7 @@ static void handle_irq_noise(struct bcm4else average -=48 ; -/* FIXME: This is wrong, but people want fancy stats. well... */ -bcm->stats.noise = average; -if (average >-65 ) - bcm->stats.link_quality =0 ; -else if (average >-75 ) - bcm->stats.link_quality =1 ; -else if (average >-85 ) - bcm->stats.link_quality =2 ; -else - bcm->stats.link_quality =3 ; -// dprintk(KERN_INFO PFX "Link Quality: %u (avg was %d)\n", bcm->stats.link_quality, average); + bcm->stats.noise = average; drop_calculation: bcm->noisecalc.calculation_running =0 ;return ;
Quoted 7 lines · Larry Finger
John,
Please queue the following patch for wireless-2.6. It removes some code that was made obsolete by the wireless statistics changes of several weeks ago, but was not noticed them.
Thanks,
Quoted 7 lines
Larry
=================
This patch removes code that was make obsolete when the wireless statistics in bcm43xx-softmac were changed, but was overlooked at that time. The value of
bcm->stats.link_qualitycomputed here is never used.
So you can also remove the actual variable, no?
Quoted 26 lines
Signed-off-by Larry Finger <[email protected]>Index:
wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
===================================================================drivers/net/wireless/bcm43xx/bcm43xx_main.c +1
-11@@ -1549,17 +1549,7 @@ static void handle_irq_noise(struct bcm4else average -=48 ; -/* FIXME: This is wrong, but people want fancy stats. well... */ -bcm->stats.noise = average; -if (average >-65 ) - bcm->stats.link_quality =0 ; -else if (average >-75 ) - bcm->stats.link_quality =1 ; -else if (average >-85 ) - bcm->stats.link_quality =2 ; -else - bcm->stats.link_quality =3 ; -// dprintk(KERN_INFO PFX "Link Quality: %u (avg was %d)\n", bcm->stats.link_quality, average); + bcm->stats.noise = average; drop_calculation: bcm->noisecalc.calculation_running =0 ;return ;
Signature · 1 line
Greetings Michael.
Quoted 7 lines · Michael Buesch
Quoted 6 lines · Larry Finger
John,
Please queue the following patch for wireless-2.6. It removes some code that was made obsolete by the wireless statistics changes of several weeks ago, but was not noticed them.
Thanks,
Quoted 7 lines
Quoted 5 lines
Larry
=================
This patch removes code that was make obsolete when the wireless statistics in bcm43xx-softmac were changed, but was overlooked at that time. The value of
bcm->stats.link_qualitycomputed here is never used.So you can also remove the actual variable, no?
Yes.
Larry