Skip to contentSkip to conversation

re-reading the partition table on a "busy" drive

DISCUSSION Michael Tokarev 4 participants 7 messages Sep 7, 2006 – Sep 8, 2006 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

Currently, the kernel refuses to re-read partition table from a drive which has usage count > 0. Motivation for this is pretty clear (to not mess up with already open devices/partitions/filesystems, if I got it right ;), but this also is pretty annoying -- in order to change unrelated, yet unused partitions on root drive, one has to reboot the machine.

I wonder if it's possible to actually read the new partition table, compare it with previous, and apply changes IF they don't conflict with currently open partitions? Say, if we have sda1 and sda2, sda1 is open/mounted, and new partition table does not have sda2, but sda1 is unchanged - it's pretty safe to apply new partition table, without affecting mounted sda1. Ditto for adding new partitions.

Yes, a line should be drawn somewhere - say, if sda3 was mounted, and we removed unused sda2, but sda3 (which becomes sda2 with new table) is intact, we should not apply new table.

Is it possible to implement such a feature? I mean, is it easy to know which *partitions* (subdevices?) of the whole device are currently in use, as opposed to the whole drive?

Thanks.

/mjt

#1 lore raw

Hallo,

Quoted 6 lines · Michael Tokarev

Currently, the kernel refuses to re-read partition table from a drive which has usage count > 0. Motivation for this is pretty clear ,
pretty annoying -- in order to change
to reboot the machine.

Yes, very interesting thing. While one will destroy its part.table, he can not see until reboot, heh. But there were days, when grub used to install itself on XFS partition (XFS isn't FAT-boot-record compatible) *silently*, but nothing was wrong to me : it's linux-gnu ;D

I would love just little kernel boot parameter to configure it, or sysctl in procfs.

Quoted 8 lines

I wonder if it's possible to actually read the new partition table, compare it with previous, and apply changes IF they don't conflict with currently open partitions? Say, if we have sda1 and sda2, sda1 is open/mounted, and new partition table does not have sda2, but sda1 is unchanged - it's pretty safe to apply new partition table, without affecting mounted sda1. Ditto for adding new partitions.

Quoted 9 lines

Yes, a line should be drawn somewhere - say, if sda3 was mounted, and we removed unused sda2, but sda3 (which becomes sda2 with new table) is intact, we should not apply new table.

Is it possible to implement such a feature? I mean, is it easy to know which *partitions* (subdevices?) of the whole device are currently in use, as opposed to the whole drive?

IMHO you've wrote much more here, then just for not-so-useless-solution, that i've wrote above, unless you want another wind0s clever-heuristic with patches from happy users to lkml: <http://article.gmane.org/gmane.linux.kernel/437388>

Quoted 3 lines

Thanks.

/mjt

Signature · 3 lines
-o--=O`C  /. .\   (+)
 #oo'L O      o    |
<___=E M    ^--    |  (you're barking up the wrong tree)
#2 lore raw
Quoted 5 lines
Quoted 1 line

Yes, very interesting thing. While one will destroy its part.table, he can not see until reboot, heh. But there were days, when grub used to install itself on XFS partition (XFS isn't FAT-boot-record compatible) *silently*, but nothing was wrong to me : it's linux-gnu ;D

People running XFS should know you cannot put boot code into the PBR.

Jan Engelhardt

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw

Oleg Verych wrote:
[]

Quoted 2 lines

My anwser to this question: if it's so "pretty annoying", just let it be "yes, do as i said !", not more and not less, just most ;).

Well, this whole question is already moot, as pointed out by Olaf. Because kernel already supports add/delete single partition ioctls, which is sufficient. For my needs I already wrote a tiny hack which compares /proc/partitions with the output of `sfdisk -d' and re-adds anything which changed. It should be possible to do the same with parted instead of {sf,cf,f}disk without using that hack, but hell, all those fdisks (parted included) sucks badly, each in its own way, so all are being used for different parts of the task, including the hack ;)

Thanks.

/mjt

#5 lore raw
Quoted 4 lines
Quoted 3 lines

My anwser to this question: if it's so "pretty annoying", just let it be "yes, do as i said !", not more and not less, just most ;).

Quoted 9 lines

Well, this whole question is already moot, as pointed out by Olaf. Because kernel already supports add/delete single partition ioctls, which is sufficient. For my needs I already wrote a tiny hack which compares /proc/partitions with the output of `sfdisk -d' and re-adds anything which changed. It should be possible to do the same with parted instead of {sf,cf,f}disk without using that hack, but hell, all those fdisks (parted included) sucks badly, each in its own way, so all are being used for different parts of the task, including the hack ;)

So something should write the perfect utility. There are people on this list capable of this, like we have seen with git :)

Jan Engelhardt

#6 lore raw
Quoted 14 lines · Jan Engelhardt
Quoted 12 lines
Quoted 2 lines

My anwser to this question: if it's so "pretty annoying", just let it be "yes, do as i said !", not more and not less, just most ;).

Well, this whole question is already moot, as pointed out by Olaf. Because kernel already supports add/delete single partition ioctls, which is sufficient. For my needs I already wrote a tiny hack which compares /proc/partitions with the output of `sfdisk -d' and re-adds anything which changed. It should be possible to do the same with parted instead of {sf,cf,f}disk without using that hack, but hell, all those fdisks (parted included) sucks badly, each in its own way, so all are being used for different parts of the task, including the hack ;)

Quoted 1 line

So something should write the perfect utility. There are people on this list capable of this, like we have seen with git :)

As far as i can see, most of such was actually started by Linus, including linux.....

Quoted 1 line

Jan Engelhardt

Signature · 3 lines
-o--=O`C  /. .\   (+)
 #oo'L O      o    |
<___=E M    ^--    |  (you're barking up the wrong tree)
#7 lore raw
In reply to Michael Tokarev
Quoted 3 lines · Michael Tokarev

Is it possible to implement such a feature? I mean, is it easy to know which *partitions* (subdevices?) of the whole device are currently in use, as opposed to the whole drive?

Its already there, see include/linux/blkpg.h
parted uses this interface, fdisk and others use the rereadpt ioctl.