Skip to contentSkip to conversation

hwmon/pc87360: update vrm setting using

PATCH New Jim Cromie 2 participants 2 messages Sep 11, 2006 – Sep 21, 2006

Subsystems (2)
lore
Share & tools
lore

Jim Cromie

author maintainer
#0 lore raw

PATCH 1/1 hwmon/pc87360: update vrm setting using

pc87360 currently hardcodes vrm = 90 (2.4 vintage). Update it to use newer code in hwmon-vid which reads cpuid to determine the correct vid.

Signed-off-by Jim Cromie <jim.cromie at gmail.com>

---

My board has an NSC SC-1100 (a 586-mmx class cpu), which is seen as unknown,
so perhaps theres more to do / investigate, but 'unknown' is certainly accurate at this point.

Looking at hwmon-vid.c, I note:
- it looks rather complete, at least for pentium 2 and up
- there are no i586's listed, from any vendor.
- I couldnt find anything at Intel website, or elsewhere

I reluctantly conclude that no VID standard existed back then. Anyone have better / contradicting info ?

 pc87360.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/pc87360.c 2006-09-11 13:55:15.000000000 -0600 renamed from linux-2.6.18-rc6-sk/drivers/hwmon/pc87360.c 2006-08-14 21:19:24.000000000 -0600 +1 -1
diff -ruNp -X dontdiff -X exclude-diffs ../linux-2.6.18-rc6-sk/drivers/hwmon/pc87360.c vrm/drivers/hwmon/pc87360.c
@@ -917,7 +917,7 @@ static int pc87360_detect(struct i2c_ada
                        (i&0x02) ? "external" : "internal");
 
                data->vid_conf = confreg[3];
-               data->vrm = 90;
+               data->vrm = vid_which_vrm();
        }
 
        /* Fan clock dividers may be needed before any data is read */
#1 lore raw

PATCH 1/1 hwmon/pc87360: update vrm setting using

Hi Jim,

Quoted 4 lines

pc87360 currently hardcodes vrm = 90 (2.4 vintage). Update it to use newer code in hwmon-vid which reads cpuid to determine the correct vid.

Signed-off-by Jim Cromie <jim.cromie at gmail.com>

Doesn't apply :( I guess your mailer converted the tabs to spaces or something equally silly. Can you please resubmit (maybe as an attachement if you can't educate Thunderbird)?

Quoted 7 lines

---

My board has an NSC SC-1100 (a 586-mmx class cpu), which is seen as unknown,
so perhaps theres more to do / investigate, but 'unknown' is certainly accurate at this point.

Quoted 7 lines

Looking at hwmon-vid.c, I note:
- it looks rather complete, at least for pentium 2 and up
- there are no i586's listed, from any vendor.
- I couldnt find anything at Intel website, or elsewhere

I reluctantly conclude that no VID standard existed back then. Anyone have better / contradicting info ?

As far as I know the Pentium Pro was the first one to have VID pins. I'm pretty certain the regular Pentium (socket 7) and previous CPUs did not have VID pins, so it comes to no surprise that the SC1100 doesn't have any.

Thanks,

Signature · 1 line
Jean Delvare