Skip to contentSkip to conversation

hda_intel prefer 24bit instead of 20bit

PATCH Applied Nicolas GRAZIANO 2 participants 2 messages Sep 16, 2006 – Sep 19, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hda_intel prefer 24bit instead of 20bit

If I understand the hda_intel code, for format > 20bit it only advertise the SNDRV_PCM_FMTBIT_S32_LE format and play it at 32 bit, 20 bit or 24 bit.

But if the 20bit and 24bit are available, actually it prefer the 20bit format. This path is to prefer the 24bit format instead of 20bit.

Nicolas

pci/hda/hda_codec.c +2 -2
diff -r b641fc7ea072 pci/hda/hda_codec.c
@@ -1503,10 +1503,10 @@ int snd_hda_query_supported_pcm(struct h
 				formats |= SNDRV_PCM_FMTBIT_S32_LE;
 				if (val & AC_SUPPCM_BITS_32)
 					bps = 32;
+				else if (val & AC_SUPPCM_BITS_24)
+					bps = 24;
 				else if (val & AC_SUPPCM_BITS_20)
 					bps = 20;
-				else if (val & AC_SUPPCM_BITS_24)
-					bps = 24;
 			}
 		}
 		else if (streams == AC_SUPFMT_FLOAT32) { /* should be exclusive */

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

Applied
#1 lore raw

At Sat, 16 Sep 2006 23:03:04 +0200,

Quoted 8 lines · Nicolas GRAZIANO

If I understand the hda_intel code, for format > 20bit it only advertise the SNDRV_PCM_FMTBIT_S32_LE format and play it at 32 bit, 20 bit or 24 bit.

But if the 20bit and 24bit are available, actually it prefer the 20bit format. This path is to prefer the 24bit format instead of 20bit.

Applied to HG tree. Thanks.

Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV