io_uring/rsrc: ignore dummy_ubuf for buffer cloning
Jens Axboe
maintainerPATCH 1/1 io_uring/rsrc: ignore dummy_ubuf for buffer cloning
For placeholder buffers, &dummy_ubuf is assigned which is a static value. When buffers are attempted cloned, don't attempt to grab a reference to it, as we both don't need it and it'll actively fail as dummy_ubuf doesn't have a valid reference count setup.
Reported-by Lai, Yi <[email protected]>
Fixes 7cc2a6eadcd7 ("io_uring: add IORING_REGISTER_COPY_BUFFERS method")
Signed-off-by Jens Axboe <[email protected]>
---
io_uring/rsrc.c +2 -1
@@ -1176,7 +1176,8 @@ static int io_clone_buffers(struct io_ring_ctx *ctx, struct io_ring_ctx *src_ctxfor (i =0 ; i < nbufs; i++) {struct io_mapped_ubuf *src = src_ctx->user_bufs[i]; -refcount_inc (&src->refs); +if (src != &dummy_ubuf) +refcount_inc (&src->refs); user_bufs[i] = src; }
Signature · 1 line
Jens Axboe