Skip to contentSkip to conversation

off-by-one in kernel command line option parsing

PATCH In review Vincent Legoll 3 participants 3 messages Sep 30, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 off-by-one in kernel command line option parsing

Here is a patch for what I think is a bug in the kernel, please comment / apply as appropriate.

Generated by cg-mkpatch from a fairly recent git tree. Cross-compile tested.

Signature · 1 line
Vincent Legoll

fix memcmp() off-by-one
nolapic is 7 chars long

---
commit aa2cb4b05c437005ccff44084678948c99aa62b3
tree 54ddca6ab0ef9a29bb1ff0f452b1eaccce7b33a1
parent 4ed4b5475211fab6a0ad00eed2f9297395e7598e
author Vincent Legoll <[email protected]> Sat, 30 Sep 2006 18:52:53 +0200 committer Vincent Legoll <[email protected]> Sat, 30 Sep 2006 18:52:53 +0200

 arch/i386/kernel/setup.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/i386/kernel/setup.c +1 -1
index f168220..72bbf22 100644
@@ -869,7 +869,7 @@ #ifdef CONFIG_X86_LOCAL_APIC
 			lapic_enable();
 
 		/* disable local APIC */
-		else if (!memcmp(from, "nolapic", 6))
+		else if (!memcmp(from, "nolapic", 7))
 			lapic_disable();
 #endif /* CONFIG_X86_LOCAL_APIC */
 
#1 lore raw
Quoted 2 lines · Vincent Legoll

Here is a patch for what I think is a bug in the kernel, please comment / apply as appropriate.

That code is already gone in the latest tree.

-Andi

#2 lore raw
Quoted 1 line · Andi Kleen

That code is already gone in the latest tree.

OK, I fumbled with git and checked a not-so-recent snapshot. Sorry for the noise.

Signature · 1 line
Vincent Legoll