another ATM bug

DISCUSSION Jeff Garzik 2 participants 2 messages Oct 1, 2006

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Jeff Garzik

author

2006-10-01 13:34 UTC #0 lore raw

The following warning appears to be real:

drivers/atm/ambassador.c: In function ‘amb_open’:
drivers/atm/ambassador.c:1049: warning: ‘tx_rate_bits’ may be used uninitialized in this function

The variable is accessed before the make_rate() error code is checked, thus accessing an uninit'd value.

Jeff

Mitchell Blank Jr

2006-10-01 14:50 UTC #1 lore raw

(cc:'s trimmed again)

Quoted 5 lines · Jeff Garzik

drivers/atm/ambassador.c: In function ?amb_open?:
drivers/atm/ambassador.c:1049: warning: ?tx_rate_bits? may be used uninitialized in this function
The variable is accessed before the make_rate() error code is checked,

Or rather, the make_rate() error code isn't checked AT ALL ("error" appears to be a write-only variable) That seems to be the real bug

-Mitch