Skip to contentSkip to conversation

ieee80211: Drop and count duplicate data frames to remove 'replay detected' log messages

PATCH New Larry Finger 1 participant 1 message Oct 3, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ieee80211: Drop and count duplicate data frames to remove 'replay detected' log messages

In the SoftMAC version of the IEEE 802.11 stack, not all duplicate messages are detected. For the most part, there is no difficulty; however ifor TKIP and CCMP encryption, the duplicates result in a "replay detected" log message where the received and previous values of the TSC are identical. This change adds a new variable to the ieee80211_device structure that holds the 'seq_ctl' value for the previous frame. When a new frame repeats the value, the frame is dropped and the appropriate counter is incremented.

---

John,

This patch replaces the one that I originally sent on 9/25. This version logs the dropped packets, which addresses the objections to the previous one.

Larry

net/ieee80211/ieee80211_rx.c +5 -0
Index: wireless-2.6/net/ieee80211/ieee80211_rx.c
===================================================================
@@ -479,6 +479,11 @@ int ieee80211_rx(struct ieee80211_device
 			goto rx_exit;
 	}
 #endif
+	/* drop duplicate 802.11 retransmissions (IEEE 802.11 Chap. 9.29) */
+	if (sc == ieee->prev_seq_ctl)
+		goto rx_dropped;
+	else
+		ieee->prev_seq_ctl = sc;
 
 	/* Data frame - extract src/dst addresses */
 	if (skb->len < IEEE80211_3ADDR_LEN)
include/net/ieee80211.h +2 -0
Index: wireless-2.6/include/net/ieee80211.h
===================================================================
@@ -1076,6 +1076,8 @@ struct ieee80211_device {
 	int perfect_rssi;
 	int worst_rssi;
 
+	u16 prev_seq_ctl;	/* used to drop duplicate frames */
+
 	/* Callback functions */
 	void (*set_security) (struct net_device * dev,
 			      struct ieee80211_security * sec);