Skip to contentSkip to conversation

drivers/base/sys.c bug found

DISCUSSION Jeff Garzik 2 participants 2 messages Oct 4, 2006 – Oct 14, 2006

lore
Share & tools
lore
#0 lore raw

sysdev_driver::add is defined to return an error (as it should), but that error code is never checked.

Jeff

#1 lore raw
Quoted 2 lines · Jeff Garzik

sysdev_driver::add is defined to return an error (as it should), but that error code is never checked.

Ick, good catch.

I hate those sysdev devices...

Hm, in sysdev_driver_register() we don't want to return any error there, as it doesn't make sense to.

Shaohua, sysdev devices should not stop the notificiation if a single add() function returns an error, right? All of the individual drivers want to be notified of the device.

Bleah...did I mention I don't like these things...

thanks,

greg k-h