x86: adjust microcode handling interface
PATCH 1/1 x86: adjust microcode handling interface
Confine the knowledge that the buffer gets accessed without use of proper guest handle accessors to a single file.
Signed-off-by Jan Beulich <[email protected]>
xen/arch/x86/microcode.c +8 -3
@@ -455,7 +455,7 @@ static int do_microcode_update (void)return error; } -int microcode_update (void *buf,unsigned long len) +int microcode_update (XEN_GUEST_HANDLE (void ) buf,unsigned long len) {int ret;
@@ -464,10 +464,15 @@ int microcode_update(void *buf, unsignedreturn -EINVAL ; } +if (len != (typeof (user_buffer_size ))len) { +printk (KERN_ERR "microcode: too much data\n" ); +return -E2BIG ; + } +mutex_lock (µcode_mutex); - user_buffer = (void __user *) buf; - user_buffer_size = (int ) len; + user_buffer = buf.p; + user_buffer_size = len; ret =do_microcode_update ();
xen/arch/x86/platform_hypercall.c +2 -2
@@ -104,8 +104,8 @@ long do_platform_op(XEN_GUEST_HANDLE(xencase XENPF_microcode_update: { -extern int microcode_update (void *buf,unsigned long len); - ret =microcode_update (op->u.microcode.data.p, +extern int microcode_update (XEN_GUEST_HANDLE (void ),unsigned long len); + ret =microcode_update (op->u.microcode.data, op->u.microcode.length); }break ;