Skip to contentSkip to conversation

NAND nand_bbt.c: badblock_pattern initialization

PATCH New Konstantin Baydarov 1 participant 1 message Oct 5, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 NAND nand_bbt.c: badblock_pattern initialization

In case of AND chips(NAND_IS_AND) (struct nand_chip *)chip->badblock_pattern stay uninitialized, see nand_default_bbt().
It seems badblock_pattern is used only in nand_scan_bbt(), but it's better to initialize badblock_pattern before calling nand_scan_bbt(), like it's done for other chips.

drivers/mtd/nand/nand_bbt.c +2 -1
Index: linux-2.6.18/drivers/mtd/nand/nand_bbt.c
===================================================================
@@ -1165,7 +1165,8 @@ int nand_default_bbt(struct mtd_info *mt
 			this->bbt_md = &bbt_mirror_descr;
 		}
 		this->options |= NAND_USE_FLASH_BBT;
-		return nand_scan_bbt(mtd, &agand_flashbased);
+		this->badblock_pattern = &agand_flashbased;
+		return nand_scan_bbt(mtd, this->badblock_pattern);
 	}
 
 	/* Is a flash based bad block table requested ? */