Skip to contentSkip to conversation

git-archive --format=zip: use default version ID

PATCH In review Rene Scharfe 1 participant 1 message Jun 15, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 git-archive --format=zip: use default version ID

Use 10 for the "version needed to extract" field. This is the default value, and we want to use it because we don't do anything special. Info-ZIP's zip uses it, too.

---
 archive-zip.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
archive-zip.c +2 -2
index 3ffdad6..ae74623 100644
@@ -214,7 +214,7 @@ static int write_zip_entry(const unsigne
 
 	copy_le32(dirent.magic, 0x02014b50);
 	copy_le16(dirent.creator_version, 0);
-	copy_le16(dirent.version, 20);
+	copy_le16(dirent.version, 10);
 	copy_le16(dirent.flags, 0);
 	copy_le16(dirent.compression_method, method);
 	copy_le16(dirent.mtime, zip_time);
@@ -236,7 +236,7 @@ static int write_zip_entry(const unsigne
 	zip_dir_entries++;
 
 	copy_le32(header.magic, 0x04034b50);
-	copy_le16(header.version, 20);
+	copy_le16(header.version, 10);
 	copy_le16(header.flags, 0);
 	copy_le16(header.compression_method, method);
 	copy_le16(header.mtime, zip_time);
Signature · 1 line
1.4.2.3.gf59615