Skip to contentSkip to conversation

pvrusb2: Suppress compiler warning

PATCH New Michael Krufky 1 participant 1 message Oct 8, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 5/6 pvrusb2: Suppress compiler warning

Quoted 1 line

From 8e9961660bc5701f82970c4b5a2eb239efb5c2d1 Mon Sep 17 00:00:00 2001

From: Mike Isely <[email protected]>
Date: Sun, 24 Sep 2006 10:45:28 -0400
Subject: [PATCH] pvrusb2: Suppress compiler warning

The pvrusb2 driver needs to call video_devdata() in order to correctly transform a file pointer into a video_device pointer. Unfortunately the prototype for this function has been marked V4L1-only and there's no official substitute that I can find for V4L2. Adding to the mystery is that the implementation for this function exists whether or not V4L1 compatibility has been selected. The upshot of all this is that we get a compilation warning here about a missing prototype but the code links OK. This fix solves the warning by copying the prototype into the source file that is using it. Yes this is a hack, but it's a safe one for 2.6.18 (any alternative would be much more intrusive). A better solution should be forthcoming for the next kernel.

---
 drivers/media/video/pvrusb2/pvrusb2-v4l2.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
drivers/media/video/pvrusb2/pvrusb2-v4l2.c +6 -0
index 128e6b5..385b715 100644
@@ -32,6 +32,12 @@ #include "pvrusb2-ioread.h"
 #include <linux/videodev2.h>
 #include <media/v4l2-common.h>
 
+/* Mike Isely <[email protected]> 23-Sep-2006 - This function is prototyped
+ * only for V4L1 but is implemented regardless of the V4L1 compatibility
+ * option state.  V4L2 has no replacement for this and we need it.  For now
+ * copy the prototype here so we can avoid the compiler warning. */
+extern struct video_device* video_devdata(struct file*);
+
 struct pvr2_v4l2_dev;
 struct pvr2_v4l2_fh;
 struct pvr2_v4l2;