mmc-utils: Add CMD0 softreset and preidle command
PATCH 1/1 mmc-utils: Add CMD0 softreset and preidle command
CMD0 may be used to see if the hardware can handle a UHS card that completed the voltage switch. If a UHS card has problems coming back up after CMD0 your hardware may not support a hard reset properly.
--- mmc.c | 10 ++++++++++ mmc.h | 3 +++ mmc_cmds.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++ mmc_cmds.h | 2 ++ 4 files changed, 66 insertions(+)
mmc.c +10 -0
@@ -245,6 +245,16 @@ static struct Command commands[] = { "be 1.", NULL }, + { do_softreset,-1 , +"softreset" ,"<device>\n" +"Issues a CMD0 softreset, e.g. for testing if hardware reset for UHS works" , +NULL + }, + { do_preidle, -1, +"preidle" ,"<device>\n" +"Issues a CMD0 GO_PRE_IDLE" , +NULL + }, { 0, 0, 0, 0 } };
mmc.h +3 -0
@@ -21,6 +21,7 @@#include <linux/mmc/ioctl.h> /* From kernel linux/mmc/mmc.h */ +#define MMC_GO_IDLE_STATE 0/* bc */ #define MMC_SWITCH 6/* ac [31:0] See below R1b */ #define MMC_SEND_EXT_CSD 8/* adtc R1 */ #define MMC_SEND_STATUS 13/* ac [31:16] RCA R1 */
@@ -226,6 +227,7 @@/* From kernel linux/mmc/core.h */ +#define MMC_RSP_NONE 0/* no response */ #define MMC_RSP_PRESENT (1 << 0)#define MMC_RSP_136 (1 << 1)/* 136 bit response */ #define MMC_RSP_CRC (1 << 2)/* expect valid crc */
@@ -234,6 +236,7 @@#define MMC_CMD_AC (0 << 5)#define MMC_CMD_ADTC (1 << 5) +#define MMC_CMD_BC (2 << 5)#define MMC_RSP_SPI_S1 (1 << 7)/* one status byte */ #define MMC_RSP_SPI_BUSY (1 << 10)/* card may send busy */
mmc_cmds.c +51 -0
54 lines not on this page · raw message
mmc_cmds.h +2 -0
@@ -47,3 +47,5 @@ int do_read_cid(int argc, char **argv);int do_read_csd (int argc,char **argv);int do_erase (int nargs,char **argv);int do_general_cmd_read (int nargs,char **argv); +int do_softreset (int nargs,char **argv); +int do_preidle (int nargs,char **argv);
Signature · 5 lines
2.37.3 Hyperstone GmbH | Reichenaustr. 39a | 78467 Konstanz Managing Director: Dr. Jan Peter Berns. Commercial register of local courts: Freiburg HRB381782
Hi,
Quoted 6 lines
CMD0 may be used to see if the hardware can handle a UHS card that completed the voltage switch. If a UHS card has problems coming back up after CMD0 your hardware may not support a hard reset properly.
Signed-off-by Christian Loehle <[email protected]>
Please flag your patch as 'RESEND' - we already discuss it on July - is it not?
Quoted 63 lines
--- mmc.c | 10 ++++++++++ mmc.h | 3 +++ mmc_cmds.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++ mmc_cmds.h | 2 ++ 4 files changed, 66 insertions(+)mmc.c +10
-0@@ -245,6 +245,16 @@ static struct Command commands[] = { "be 1.", NULL }, + { do_softreset,-1 , +"softreset" ,"<device>\n" +"Issues a CMD0 softreset, e.g. for testing if hardware reset for UHS works", +NULL + }, + { do_preidle, -1, +"preidle" ,"<device>\n" +"Issues a CMD0 GO_PRE_IDLE" , +NULL + }, { 0, 0, 0, 0 } };mmc.h +3
-0@@ -21,6 +21,7 @@#include <linux/mmc/ioctl.h> /* From kernel linux/mmc/mmc.h */ +#define MMC_GO_IDLE_STATE 0/* bc */ #define MMC_SWITCH 6/* ac [31:0] See below R1b */ #define MMC_SEND_EXT_CSD 8/* adtc R1 */ #define MMC_SEND_STATUS 13/* ac [31:16] RCA R1 */ @@ -226,6 +227,7 @@/* From kernel linux/mmc/core.h */ +#define MMC_RSP_NONE 0/* no response */ #define MMC_RSP_PRESENT (1 << 0)#define MMC_RSP_136 (1 << 1)/* 136 bit response */ #define MMC_RSP_CRC (1 << 2)/* expect valid crc */ @@ -234,6 +236,7 @@#define MMC_CMD_AC (0 << 5)#define MMC_CMD_ADTC (1 << 5) +#define MMC_CMD_BC (2 << 5)#define MMC_RSP_SPI_S1 (1 << 7)/* one status byte */ #define MMC_RSP_SPI_BUSY (1 << 10)/* card may send busy */ mmc_cmds.c +0
-0
mmc_cmds.c out: · line 3048
Quoted 5 lines
mmc_cmds.c +2
-0@@ -3044,3 +3044,54 @@ out:close (dev_fd);return ret; } + +void issue_cmd0 (char *device,__u32 arg)
Static void?
Quoted 21 lines
mmc_cmds.c +21
-0+{ +struct mmc_ioc_cmd idata; +int fd; + + fd =open (device,O_RDWR ); +if (fd <0 ) { +perror ("open" ); +exit (1 ); + } + +memset (&idata,0 ,sizeof (idata)); + idata.opcode =MMC_GO_IDLE_STATE ; + idata.arg = arg; + idata.flags =MMC_RSP_NONE |MMC_CMD_BC ; + +/* No need to check for error, it is expected */ +ioctl (fd,MMC_IOC_CMD , &idata); +close (fd); +} + +int do_softreset (int nargs,char **argv)
mmc_cmds.c out: · line 3079
Quoted 10 lines
mmc_cmds.c +10
-0+{ +char *device; + +if (nargs !=2 ) { +fprintf (stderr,"Usage: mmc softreset </path/to/mmcblkX>\n" ); +exit (1 ); + } + + device = argv[1 ]; +issue_cmd0 (device,0x0 );
Maybe use GO_IDLE_STATE macro?
Quoted 5 lines
mmc_cmds.c +5
-0+ +return 0 ; +} + +int do_preidle (int nargs,char **argv)
mmc_cmds.c out: · line 3094
Quoted 10 lines
mmc_cmds.c +10
-0+{ +char *device; + +if (nargs !=2 ) { +fprintf (stderr,"Usage: mmc preidle </path/to/mmcblkX>\n" ); +exit (1 ); + } + + device = argv[1 ]; +issue_cmd0 (device,0xf0f0f0f0 );
Maybe use GO_PRE_IDLE_STATE macro?
Thanks,
Avri
Quoted 19 lines
mmc_cmds.c +3
-0+ +return 0 ; +}mmc_cmds.h +2
-1@@ -47,3 +47,5 @@ int do_read_cid(int argc, char **argv);int do_read_csd (int argc,char **argv);int do_erase (int nargs,char **argv);int do_general_cmd_read (int nargs,char **argv); +int do_softreset (int nargs,char **argv); +int do_preidle (int nargs,char **argv); --2.37.3
Hyperstone GmbH | Reichenaustr. 39a | 78467 Konstanz Managing Director: Dr. Jan Peter Berns. Commercial register of local courts: Freiburg HRB381782