Skip to contentSkip to conversation

coretemp driver

PATCH New Rudolf Marek 3 participants 8 messages Oct 15, 2006 – Nov 12, 2006

lore
Share & tools
lore
#0 lore raw

cover coretemp driver

Hello all,

Following series of patches adds support for the temperature sensors inside the Intel Core family processors.

It would be nice if someone could test the stuff again and read the documentation and code to see if all is OK

Thanks,
Regards
Rudolf

#1 lore raw

cover coretemp driver

Quoted 2 lines

It would be nice if someone could test the stuff again and read the documentation and code to see if all is OK

Oh I forgot. There is new detection code in sensors-detect and all userspace stuff is now available in lm-sensors SVN.

Good night,
Rudolf

#2 lore raw

cover coretemp driver

In reply to Rudolf Marek

Hello Rudolf,

Am Sonntag, den 15.10.2006, 22:17 +0200 schrieb Rudolf Marek:

Quoted 7 lines

Hello all,

Following series of patches adds support for the temperature sensors inside the Intel Core family processors.

It would be nice if someone could test the stuff again and read the documentation and code to see if all is OK

I've just applied this patchset to 2.6.19-rc2. If I enable "Processor type and features / Support for hot-pluggable CPUs (EXPERIMENTAL)", the coretemp driver no longer compiles (not as module and not compiled into the kernel).

Thanks,

Signature · 17 lines
Matthias 'CoreDump' Hentges 

My OS: Debian SID. Geek by Nature, Linux by Choice
-------------- next part --------------
A non-text attachment was scrubbed...
Name: make_bzImage.tmp.gz
Type: application/x-gzip
Size: 2257 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20061016/fe00d9a3/attachment.gz 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Dies ist ein digital signierter Nachrichtenteil
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20061016/fe00d9a3/attachment.bin 
#3 lore raw

cover coretemp driver

In reply to Rudolf Marek

Hello Mattias,

Thanks for the test.

Quoted 4 lines

I've just applied this patchset to 2.6.19-rc2. If I enable "Processor type and features / Support for hot-pluggable CPUs (EXPERIMENTAL)", the coretemp driver no longer compiles (not as module and not compiled into the kernel).

Please do not include the binary attachments, the mailing list will throw such mails away...

Quoted 7 lines

coretemp.c:(.init.text+0x6e0d): undefined reference to register_hotcpu_notifier' drivers/built-in.o: In function coretemp_exit':

coretemp.c:(.exit.text+0x82f): undefined reference to `unregister_hotcpu_notifier'
make: *** [.tmp_vmlinux1] Fehler 1

Hmm I tried with the rc2 and it does work. (it reports just a complain about missing function prototype - I fixed that). Please can you send me your .config file? Maybe you need to make clean; before doing the test?

Thanks,
Rudolf

#4 lore raw

cover coretemp driver

In reply to Rudolf Marek

Hello Rudolf,

Am Montag, den 16.10.2006, 20:22 +0200 schrieb Rudolf Marek:

Quoted 3 lines

Hello Mattias,

Thanks for the test.

thanks for your work on the driver ;)

[...]

Quoted 2 lines

Please do not include the binary attachments, the mailing list will throw such mails away...

Sorry for that, I'll try to keep it in mind.

Quoted 11 lines
Quoted 7 lines

coretemp.c:(.init.text+0x6e0d): undefined reference to register_hotcpu_notifier' drivers/built-in.o: In function coretemp_exit':

coretemp.c:(.exit.text+0x82f): undefined reference to `unregister_hotcpu_notifier'
make: *** [.tmp_vmlinux1] Fehler 1

Hmm I tried with the rc2 and it does work. (it reports just a complain about missing function prototype - I fixed that). Please can you send me your .config file? Maybe you need to make clean; before doing the test?

I certainly made sure to run "make clean" after each run =) You can find my kernel .configs here:
http://hentges.net/tmp/debug/asus-p5w-dh-deluxe/lm-sensors/coretemp/20061016/

Thanks,

Signature · 10 lines
Matthias 'CoreDump' Hentges 

My OS: Debian SID. Geek by Nature, Linux by Choice
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Dies ist ein digital signierter Nachrichtenteil
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20061017/f572111e/attachment.bin 
#5 lore raw

cover coretemp driver

In reply to Rudolf Marek

Hi Rudolf,

concerning:

Quoted 7 lines

coretemp.c:(.init.text+0x6e0d): undefined reference to register_hotcpu_notifier' drivers/built-in.o: In function coretemp_exit':

coretemp.c:(.exit.text+0x82f): undefined reference to `unregister_hotcpu_notifier'
make: *** [.tmp_vmlinux1] Fehler 1

I found the problem: you have to include one more header file:

37d36
< #include <linux/cpu.h>

and it works! --> please add the line to your sources.

The bug is noticable only if you switch on HOTPLUG_CPU otherwise it does not appear.

Best regards
Christian

PS many thanks for the driver, I do use it in 2.6.18.1
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20061112/f82e56dc/attachment.html

#6 lore raw

cover coretemp driver

In reply to Rudolf Marek
Quoted 3 lines · Christian Mahr

Hi Rudolf,

concerning:

Hi,

Did you use the patch from 17.10.2006 23:31 I think I fixed that.

Regards
Rudolf

#7 lore raw

cover coretemp driver

In reply to Rudolf Marek

Rudolf pointed me to the most recent version of the patch . this does include the fix already. Sorry to bother

Christian

Am Sonntag, 12. November 2006 12:16 schrieb Christian Mahr:

Quoted 18 lines

Hi Rudolf,

concerning:

Quoted 7 lines

coretemp.c:(.init.text+0x6e0d): undefined reference to register_hotcpu_notifier' drivers/built-in.o: In function coretemp_exit':

coretemp.c:(.exit.text+0x82f): undefined reference to `unregister_hotcpu_notifier'
make: *** [.tmp_vmlinux1] Fehler 1

I found the problem: you have to include one more header file:

37d36
< #include <linux/cpu.h>

and it works! --> please add the line to your sources.

Quoted 7 lines

The bug is noticable only if you switch on HOTPLUG_CPU otherwise it does not appear.

Best regards
Christian

PS many thanks for the driver, I do use it in 2.6.18.1

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20061112/9e330b29/attachment.html