Large Block Device patch part 5/4

PATCH Peter Chubb 1 participant 1 message Oct 3, 2002 1 message not in the archive

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Peter Chubb

author

2002-10-03 22:39 UTC #1 lore raw

Quoted 1 line

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Russell" == Russell King <[email protected]> writes:

Russell> On Thu, Oct 03, 2002 at 03:49:33PM +1000,

Quoted 8 lines · Russell> [email protected] wrote:

Quoted 8 lines
+#ifdef CONFIG_LBD extern u64 __udivdi3(u64, u64); extern u64 __umoddi3(u64, u64); +EXPORT_SYMBOL(__udivdi3); +EXPORT_SYMBOL(__umoddi3); +#endif EXPORT_SYMBOL(md_size); EXPORT_SYMBOL(register_md_personality); EXPORT_SYMBOL(unregister_md_personality); @@ -3493,6 +3497,4 @@ EXPORT_SYMBOL(md_wakeup_thread); EXPORT_SYMBOL(md_print_devices); EXPORT_SYMBOL(md_interrupt_thread); -EXPORT_SYMBOL(__udivdi3); -EXPORT_SYMBOL(__umoddi3); MODULE_LICENSE("GPL");

Russell> These exports should be performed by the architecture not by Russell> generic drivers.

1. CONFIG_LBD is defined only for IA32 and PPC32.
2. The exports are temporary until other stuff in the RAID code is cleaned up.
3. They're only used by the RAID code, and would be the same for all architectures that use gcc, assuming that CONFIG_LBD were to be turned on for those architectures.

Russell> Please move them into all architectures.

I'd rather remove them entirely, and am working on that. In the meantime, they'll stay (probably until Neil Brown gets back from holiday next week and can help with my RAID problems)

Peter C