ixdp 465
A message that is not in the archive (sent off-list or not yet received): [email protected]
Dear Michael,
Quoted 2 lines · in message <[email protected]> you wrote:
Quoted 2 lines
Ummm... which patch are you referring to?
Areghhh. Please NEVER send patches to my address. Always send these through the mailing list only, so others can comment on these, too.
Quoted 5 lines
diff -raN u-boot-1.1.4.orig/Makefile u-boot-1.1.4/Makefile 1614a1615,1617
Quoted 3 lines
ixdp465_config: unconfig@./mkconfig $(@:_config=) arm ixp ixdp465
Such a plain diff output is not a patch, it cannot be applied. Please make sure to read the README, section Submitting Patches. You MUST use the correct options when creating the patch.
Also mind the size limitations on the mailing list.
And make sure to stick to the required coding style, your code contains lots of problems (indentation by spaces instead of TABs, C++ comments, trailing white space, etc.).
Also never add change log entires to any files. We use git for this purpose.
Make sure your code does not contain dead code (#if 0 etc.).
Please cleanup and resubmit.
Best regards,
Wolfgang Denk
Signature · 4 lines
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I'm a programmer: I don't buy software, I write it.
-- Tom ChristiansenHi,
Quoted 4 lines · Wolfgang Denk
Such a plain diff output is not a patch, it cannot be applied. Please make sure to read the README, section Submitting Patches. You MUST use the correct options when creating the patch.
Ok, some people ask me for a patch because they need it. I will produce a better patch.
Quoted 7 lines
Also mind the size limitations on the mailing list.
And make sure to stick to the required coding style, your code contains lots of problems (indentation by spaces instead of TABs, C++ comments, trailing white space, etc.).
thank's,
I'm going to fix
Quoted 4 lines
Also never add change log entires to any files. We use git for this purpose.
Ok
Quoted 3 lines
Make sure your code does not contain dead code (#if 0 etc.).
The dead code is already present, I just add my code, without dead code. Thank's a lot for your comment
Quoted 10 lines
Please cleanup and resubmit.
Best regards,
Wolfgang Denk
Regards Michael