Skip to contentSkip to conversation

ARM: OMAP: Fix warnings in plat-omap

PATCH New Dirk Behme 1 participant 1 message Oct 27, 2006

Subsystems (2)
lore
Share & tools
lore

Dirk Behme

author
#0 lore raw

PATCH 1/1 ARM: OMAP: Fix warnings in plat-omap

Fix warnings

arch/arm/plat-omap/dmtimer.c: In function 'omap_dm_timer_modify_idlect_mask':
arch/arm/plat-omap/dmtimer.c:317: warning: no return statement in function returning non-void

arch/arm/plat-omap/mailbox.c: In function 'omap_mbox_init':
arch/arm/plat-omap/mailbox.c:231: warning: ignoring return value of 'class_device_create_file', declared with attribute warn_unused_result

Signed-off-by Dirk Behme <dirk.behme_at_gmail.com>
arch/arm/plat-omap/mailbox.c +6 -1
Index: linux-osk/arch/arm/plat-omap/mailbox.c
===================================================================
@@ -228,7 +228,12 @@ static int omap_mbox_init(struct omap_mb
 	if (unlikely(ret))
 		return ret;
 
-	class_device_create_file(&mbox->class_dev, &class_device_attr_mbox);
+	ret = class_device_create_file(&mbox->class_dev, &class_device_attr_mbox);
+	if (unlikely(ret)) {
+		printk(KERN_ERR
+		       "class_device_create_file failed: %d\n", ret);
+		goto fail1;
+	}
 
 	ret = request_irq(mbox->irq, mbox_interrupt, SA_INTERRUPT,
 			  mbox->name, mbox);
arch/arm/plat-omap/dmtimer.c +2 -0
Index: linux-osk/arch/arm/plat-omap/dmtimer.c
===================================================================
@@ -314,6 +314,8 @@ struct clk *omap_dm_timer_get_fclk(struc
 __u32 omap_dm_timer_modify_idlect_mask(__u32 inputmask)
 {
 	BUG();
+
+	return 0;
 }
 
 #endif