Mark platform device data as const
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 2 lines · Jeremy Kerr
platform_device_add_data()'s data argument can be qualified as const - the function just copies it to another buffer.
Ummm, you change the actual function definition here, but you put the change to the declaration in include/linux/platform_device.h in your [5/20] patch. Please redo this patch with the change to the declaration included.
Paul.
PATCH 1/1 Mark platform device data as const
platform_device_add_data()'s data argument can be qualified as const - the function just copies it to another buffer.
This neatens-up storing other const-ed data there.
Built for powerpc and i386
Signed-off-by Jeremy Kerr <[email protected]>
---
resend: Include the platform_device.h change this time.
drivers/base/platform.c | 3 ++- include/linux/platform_device.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-)
drivers/base/platform.c +2 -1
@@ -212,7 +212,8 @@ EXPORT_SYMBOL_GPL(platform_device_add_re* pointer. The memory associated with the platform data will be freed * when the platform device is released. */ -int platform_device_add_data (struct platform_device *pdev,void *data,size_t size) +int platform_device_add_data (struct platform_device *pdev,const void *data, +size_t size) {void *d;
include/linux/platform_device.h +2 -1
@@ -39,7 +39,8 @@ extern struct platform_device *platform_extern struct platform_device *platform_device_alloc (const char *name,unsigned int id);extern int platform_device_add_resources (struct platform_device *pdev,struct resource *res,unsigned int num); -extern int platform_device_add_data (struct platform_device *pdev,void *data,size_t size); +extern int platform_device_add_data (struct platform_device *pdev, +const void *data,size_t size);extern int platform_device_add (struct platform_device *pdev);extern void platform_device_del (struct platform_device *pdev);extern void platform_device_put (struct platform_device *pdev);