ARM: OMAP: Fix broken N770 build
Subsystems (3)
PATCH 1/1 ARM: OMAP: Fix broken N770 build
Make build of N770 work again.
arch/arm/mach-omap1/board-nokia770.c +1 -1
@@ -76,7 +76,7 @@ static struct omap_kp_platform_data noki .rows = 8, .cols = 8, .keymap = nokia770_keymap, - .keymapsize = ARRAY_SIZE(nokia770_keymap) + .keymapsize = ARRAY_SIZE(nokia770_keymap), .delay = 4, };
arch/arm/configs/n770_defconfig +40 -1
48 lines not on this page · raw message
drivers/cbus/tahvo-usb.c +1 -1
@@ -36,7 +36,7 @@#include <linux/usb_ch9.h> #include <linux/usb_gadget.h> #include <linux/usb.h> -#include <linux/usb_otg.h> +#include <linux/usb/otg.h> #include <linux/i2c.h> #include <linux/workqueue.h> #include <linux/kobject.h>
Tony Lindgren
reviewerQuoted 5 lines · Dirk Behme
Make build of N770 work again.
Signed-off-by Dirk Behme <dirk.behme_at_gmail.com>
Pushing today, I split it into two patches as tahvo-usb is not in the mainline. Also left out the defconfig changes as they don't seem to do anything. Let me know if something is needed on the defconfig.
Regards,
Tony
Quoted 3 lines · Tony Lindgren
Also left out the defconfig changes as they
don't seem to do anything. Let me know if something is needed on the defconfig.
In -rc4 CONFIG_HWMON wasn't evaluated to y necessary to build stuff cleanly. Seems that in -rc5 this is fixed. Now, CONFIG_HWMON is default y and n770_defconfig builds fine without the defconfig patch.
Thanks for updates,
Dirk
Btw: Last warning I see with n770_defconfig in our code is
arch/arm/plat-omap/sti/sti-console.c: In function 'sti_channel_puts':arch/arm/plat-omap/sti/sti-console.c:48: warning: value computed is not used arch/arm/plat-omap/sti/sti-console.c:57: warning: value computed is not used
Anybody with an idea here?
Quoted 16 lines · Dirk Behme
Quoted 3 lines · Tony Lindgren
Also left out the defconfig changes as they
don't seem to do anything. Let me know if something is needed on the defconfig.In -rc4
CONFIG_HWMONwasn't evaluated to y necessary to build stuff cleanly. Seems that in -rc5 this is fixed. Now,CONFIG_HWMONis default y andn770_defconfigbuilds fine without the defconfig patch.Thanks for updates,
Dirk
Btw: Last warning I see with
n770_defconfigin our code is
Quoted 8 lines
arch/arm/plat-omap/sti/sti-console.c: In function 'sti_channel_puts':arch/arm/plat-omap/sti/sti-console.c:48: warning: value computed is not usedarch/arm/plat-omap/sti/sti-console.c:57: warning: value computed is not usedAnybody with an idea here?
Well, at least you don't need to worry about that warning... I'm pretty certain you don't have an sti-console anyway.
Regards: David
Signature · 3 lines
/) David Weinehall <[email protected]> /) Northern lights wander (\ // Maintainer of the v2.0 kernel // Dance across the winter sky // \) http://www.acc.umu.se/~tao/ (/ Full colour fire (/