Skip to contentSkip to conversation

very small code cleanup

PATCH Rik Bobbaers 3 participants 3 messages Nov 7, 2006

lore
Share & tools
lore
#0 lore raw

hey all,

in mm/mlock.c , mm is defined as vma->vm_mm, why not use that one for the decrement of pages?

proposed patch:
---------------

mlock.c 2006-11-07 15:23:48.000000000 +0100 renamed from mlock.c~ 2006-11-04 02:33:58.000000000 +0100 +1 -1
@@ -65,7 +65,7 @@ success:
                        ret = make_pages_present(start, end);
        }
 
-       vma->vm_mm->locked_vm -= pages;
+       mm->locked_vm -= pages;
 out:
        if (ret == -ENOMEM)
                ret = -EAGAIN;

---------------

tnx...

Signature · 10 lines
harry
aka Rik Bobbaers

K.U.Leuven - LUDIT          -=- Tel: +32 485 52 71 50
[email protected] -=- http://people.linux-vserver.org/~harry

thinking always leads to conclusions... and those can be extremely dangerous
-- me ;)

Disclaimer: http://www.kuleuven.be/cwis/email_disclaimer.htm
#1 lore raw
Quoted 3 lines · Rik Bobbaers

hey all,

in mm/mlock.c , mm is defined as vma->vm_mm, why not use that one for the decrement of pages?

Because vma can change here:

	if (*prev) {
		vma = *prev;
		goto success;
	}

and then mm won't be the same as vma->vm_mm..

Signature · 4 lines
Paulo Marques - www.grupopie.com

"The face of a child can say it all, especially the
mouth part of the face."
#2 lore raw
Quoted 11 lines · Paulo Marques
Quoted 3 lines · Rik Bobbaers

in mm/mlock.c , mm is defined as vma->vm_mm, why not use that one for the decrement of pages?

Because vma can change here:

	if (*prev) {
		vma = *prev;
		goto success;
	}

That's a good piece of cautious observation ...

Quoted 2 lines

and then mm won't be the same as vma->vm_mm..

... but it would be a bug if *prev's vm_mm were different from mm and from the original vma->vm_mm: Rik's patch looks sensible to me.

Hugh