Skip to contentSkip to conversation

ixdp465 support

U-Boot-Users Michael Trimarchi 4 participants 4 messages Nov 14, 2006 – Nov 18, 2006

lore
Share & tools
lore
#1 lore raw
Quoted 6 lines · In message <[email protected]> you wrote:

since we didn't have enough spare time to prepare a clean patch for
the IXDP465 support, we decided to put the current patch on our website
(http://www.evidence.eu.com/content/view/104/119/).

The patch is released under GPL license.

It is *extremely* bad style to post the same information with slightly different text to different mailing lists.

Here is a copy of my reply to Claudio Scordino's posting on the linux-arm list:

------- Forwarded Message

Date:    Tue, 14 Nov 2006 21:49:51 +0100
From:    Wolfgang Denk <[email protected]>
To:      Claudio Scordino <[email protected]>

cc: Arm Linux <[email protected]>
Subject: Re: U-boot on Intel IXDP465

Quoted 4 lines · In message <[email protected]> you wrote:

=20
Evidence Srl has just finished the porting of the U-boot bootloader to the Intel IXDP465 development platform (featuring a Intel IXP465 Xscale microprocessor). The patch adds the support for the microprocessor, the

So why don't you post it to the appropirate mailing list, i. e. u-boot-users? It's off topic here.

Note 1: the resulting binary cannot be distributed, as you have a
license conflict with the Intel NPE code. You MUST NOT link U-Boot (under GPL) with this code.

Note 2: your patch contains garbage; for example, it creates files
like Makefile.orig, cpu/ixp/cpu.c.orig, cpu/ixp/interrupts.c.orig, cpu/ixp/serial.c.orig, cpu/ixp/timer.c.orig, drivers/pci_indirect.c.orig, cpu/ixp/config.mk.orig, ... which must not be included.

Also, pippo.txt is poroibably random garbage and should not be included.

Note 3: For CFI conformant flash chips you should use the CFI driver
instead of a custom one.

Note 4: Your patch violates the coding style (C++ comments,
trailing white space, indentation not by TABs, etc.). Please cleanup.

Note 5: You patch adds debug code to common files (like
common/cmd_bootm.c). You must never do this!

Note 6: Please doin;t add changelog style comments to files (like in
cpu/ixp/start.S); we use git to track the history.

Note 7: Please don't modify white space in files which you don't
touch at all (like drivers/cfi_flash.c).

Note 8: Be careful with hardware accesses; code like function
get_reg() in drivers/ethixdp465.c is missing "volatile" attributes. Check all your code for this!

So please clean up your code, fix the license issue, and (re-) submit your code on u-boot-users.

Best regards,

Wolfgang Denk

Signature · 22 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Every little picofarad has a nanohenry all its own.      - Don Vonada

------- End of Forwarded Message



And please don't try to put the burdon to clean up your
mess^H^H^H^Hcode on others!

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Nearly everyone is in favor of going  to  heaven  but  too  many  are
hoping  they'll  live  long  enough  to see an easing of the entrance
requirements. Never appeal to a man's "better nature." he  might  not
have one.
#2 lore raw
Quoted 6 lines · Wolfgang Denk
Quoted 4 lines · In message <[email protected]> you wrote:

since we didn't have enough spare time to prepare a clean patch for
the IXDP465 support, we decided to put the current patch on our website
(http://www.evidence.eu.com/content/view/104/119/).

Quoted 6 lines
Quoted 2 lines

The patch is released under GPL license.

It is *extremely* bad style to post the same information with slightly different text to different mailing lists.

My apologies: I recently moved from an email client to another one and I messed up...
Of course, it's a bad style. Sorry.

Quoted 19 lines

Here is a copy of my reply to Claudio Scordino's posting on the linux-arm list:

------- Forwarded Message

Date:    Tue, 14 Nov 2006 21:49:51 +0100
From:    Wolfgang Denk <[email protected]>
To:      Claudio Scordino <[email protected]>

cc: Arm Linux <[email protected]>
Subject: Re: U-boot on Intel IXDP465

Quoted 5 lines · In message <[email protected]> you wrote:

=20
Evidence Srl has just finished the porting of the U-boot bootloader to the Intel IXDP465 development platform (featuring a Intel IXP465 Xscale microprocessor). The patch adds the support for the microprocessor, the

Quoted 7 lines

So why don't you post it to the appropirate mailing list, i. e. u-boot-users? It's off topic here.

Note 1: the resulting binary cannot be distributed, as you have a
license conflict with the Intel NPE code. You MUST NOT link U-Boot (under GPL) with this code.

Our idea is to release the patch *without* the Intel Microcode, so that the patch can be released under GPL license.
Clearly, once you copy the Microcode (which is not GPL) and compile, the resulting binary is not GPL, due to Intel's license.
But it wouldn't be in any case...

Quoted 9 lines

Note 2: your patch contains garbage; for example, it creates files
like Makefile.orig, cpu/ixp/cpu.c.orig, cpu/ixp/interrupts.c.orig, cpu/ixp/serial.c.orig, cpu/ixp/timer.c.orig, drivers/pci_indirect.c.orig, cpu/ixp/config.mk.orig, ... which must not be included.

Also, pippo.txt is poroibably random garbage and should not be included.

As I said, we are experiencing a very busy period, and we didn't have enough time to properly clear the patch and submit it on the u-boot mailing list. We know that the patch is still very dirty. That's why we didn't ask to put it in the U-boot mainstream. But we wanted to release this alpha version on our website because someone may be interested. In the next weeks we'll provide a clean version of the patch.

Quoted 3 lines

Note 3: For CFI conformant flash chips you should use the CFI driver
instead of a custom one.

If I'm not wrong, IXP425 uses a custom driver too. That's why we chose to go for a custom driver.

Quoted 4 lines

Note 4: Your patch violates the coding style (C++ comments,
trailing white space, indentation not by TABs, etc.). Please cleanup.

We'll fix this.
BTW, why indentation should not done by TABs ? In the Linux kernel code the use of TABs is mandatory...

Quoted 7 lines

Note 5: You patch adds debug code to common files (like
common/cmd_bootm.c). You must never do this!

Note 6: Please doin;t add changelog style comments to files (like in
cpu/ixp/start.S); we use git to track the history.

Quoted 7 lines

Note 7: Please don't modify white space in files which you don't
touch at all (like drivers/cfi_flash.c).

Note 8: Be careful with hardware accesses; code like function
get_reg() in drivers/ethixdp465.c is missing "volatile" attributes. Check all your code for this!

We'll fix all these issues.

Quoted 3 lines

So please clean up your code, fix the license issue, and (re-) submit your code on u-boot-users.

Ok. I don't know exactly when the final patch will be ready. In the meanwhile we put a new version (slightly better) on the same URL for those people that can't wait the final version.

Best regards,

Claudio Scordino

=================================
Claudio Scordino
Software Engineer
IEEE Memmber

Evidence Srl
Embedded Real-Time solutions
http://www.evidence.eu.com
=================================

#3 lore raw
Quoted 5 lines · Claudio Scordino
Quoted 2 lines

Note 3: For CFI conformant flash chips you should use the CFI driver
instead of a custom one.

If I'm not wrong, IXP425 uses a custom driver too. That's why we chose to go for a custom driver.

There is no "IXP425" target in the current U-Boot tree. The "ixdp425" and "ixdpg425" targets both use the CFI driver. Only the "pdnb3" uses a custom driver because of a non CFI compliant FLASH.

Please recheck if your board has CFI compatible FLASH's and if so, reconfigure your config file to use the CFI driver.

Quoted 7 lines
Quoted 3 lines

Note 4: Your patch violates the coding style (C++ comments,
trailing white space, indentation not by TABs, etc.). Please cleanup.

We'll fix this.
BTW, why indentation should not done by TABs ? In the Linux kernel code the use of TABs is mandatory...

Yes. Wolfgang meant you used indentation with spaces in some places. Please change this to tabs.

Quoted 6 lines
Quoted 2 lines

So please clean up your code, fix the license issue, and (re-) submit your code on u-boot-users.

Ok. I don't know exactly when the final patch will be ready. In the meanwhile we put a new version (slightly better) on the same URL for those people that can't wait the final version.

Thanks.

Best regards,
Stefan