Skip to contentSkip to conversation

sas_ata: don't copy aic94xx's sactive to ata_port

PATCH New Darrick J. Wong 1 participant 1 message Nov 14, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sas_ata: don't copy aic94xx's sactive to ata_port

Since the aic94xx sequencer assigns its own NCQ tags to ATA commands, it no longer makes any sense to copy the sactive field in the STP response to ata_port->sactive, as that will confuse libata. Also, libata seems to be capable of managing sactive on its own.

The attached patch gets rid of one of the causes of the BUG messages in ata_qc_new, and should apply against jejb's aic94xx-sas git tree.

--

drivers/scsi/libsas/sas_ata.c +0 -1
index ca49d3e..9580d81 100644
@@ -108,7 +108,6 @@ static void sas_ata_task_done(struct sas
 		dev->sata_dev.sstatus = resp->sstatus;
 		dev->sata_dev.serror = resp->serror;
 		dev->sata_dev.scontrol = resp->scontrol;
-		dev->sata_dev.ap->sactive = resp->sactive;
 	} else if (stat->stat != SAM_STAT_GOOD) {
 		ac = sas_to_ata_err(stat);
 		if (ac) {