Skip to contentSkip to conversation

BUG: 2.6.19-rc6 net/irda/irlmp.c

DISCUSSION Ian Molton 4 participants 6 messages Nov 23, 2006

lore
Share & tools
lore

Ian Molton

author
#0 lore raw

spin_lock_irqsave_nested is used in net/irda/irlmp.c

Im not sure what it _should_ be, but thought it worth reporting.

#1 lore raw
Quoted 3 lines · Ian Molton

spin_lock_irqsave_nested is used in net/irda/irlmp.c

Im not sure what it _should_ be, but thought it worth reporting.

I reported this yesterday - http://lkml.org/lkml/2006/11/22/137 - It is commit 700f9672c9a61c12334651a94d17ec04620e1976 that breaks the build.

Linus: I think that commit should either be reverted or fixed in a different way before 2.6.19. As it is right now we have a build failure :

net/built-in.o: In function `irlmp_slsap_inuse':
net/irda/irlmp.c:1681: undefined reference to `spin_lock_irqsave_nested'
make: *** [.tmp_vmlinux1] Error 1

Signature · 3 lines
Jesper Juhl <[email protected]>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
#3 lore raw
Quoted 9 lines · Peter Zijlstra
Quoted 2 lines · Jesper Juhl

Linus: I think that commit should either be reverted or fixed in a different way before 2.6.19.

Andrew already said he'd push the required patches to Linus:

http://lkml.org/lkml/2006/11/22/283

Ahh, OK, I had missed that. Thank you for pointing that out.

Signature · 3 lines
Jesper Juhl <[email protected]>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
#4 lore raw
In reply to Jesper Juhl

From: "Jesper Juhl" <[email protected]>
Date: Thu, 23 Nov 2006 14:13:12 +0100

Quoted 11 lines

I reported this yesterday - http://lkml.org/lkml/2006/11/22/137 - It is commit 700f9672c9a61c12334651a94d17ec04620e1976 that breaks the build.

Linus: I think that commit should either be reverted or fixed in a different way before 2.6.19. As it is right now we have a build failure :

net/built-in.o: In function `irlmp_slsap_inuse':
net/irda/irlmp.c:1681: undefined reference to `spin_lock_irqsave_nested'
make: *** [.tmp_vmlinux1] Error 1

Andrew will push the change which will fix this bug, please be patient.

#5 lore raw
In reply to Ian Molton

From: Ian Molton <[email protected]>
Date: Thu, 23 Nov 2006 10:45:40 +0000

Quoted 3 lines

spin_lock_irqsave_nested is used in net/irda/irlmp.c

Im not sure what it _should_ be, but thought it worth reporting.

This has been reported, and explained, about 3 times already.

Andrew Morton will be pushing in a patch to fix this.