Skip to contentSkip to conversation

Fix vfio-ccw handling of TIC recursion

PATCH Cornelia Huck 1 participant 1 message Feb 26, 2019 1 message not in the archive s390

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Cornelia Huck

author Applied
#1 lore raw
Quoted 16 lines · On Fri, 22 Feb 2019 19:39:39 +0100 Eric Farman <[email protected]> wrote:

Per the discussion [1] about a problem with how vfio-ccw calculates the length of a channel program (specifically when using the forthcoming QEMU BIOS code for DASD IPL), I present this fix.

Patch 1 fixes the problem, and is over-engineered
for readability sake.

Patch 2 takes the functions from Patch 1, and refactors the existing code to make other areas a little easier to understand. (I hope.)

I've been running fio for over 24 hours now, and have seen zero hours. Previously, I would have probably seen "a few" errors by now, where prior to the original fix I would've seen "many" errors. Further tests are still ongoing.

Quoted 9 lines

[1] https://marc.info/?l=linux-s390&m=155063096321940&w=2

Eric Farman (2):
s390/cio: Fix vfio-ccw handling of recursive TICs s390/cio: Use cpa range elsewhere within vfio-ccw

 drivers/s390/cio/vfio_ccw_cp.c | 55 ++++++++++++++++++++++++++++++++----------
 1 file changed, 42 insertions(+), 13 deletions(-)

Thanks, applied.