Skip to contentSkip to conversation

on stack space....

DISCUSSION Eric Sandeen 1 participant 1 message Dec 1, 2006

lore
Share & tools
lore
#0 lore raw

On the issue of stack space & where it goes in xfs...

<arjan> checkstack does not count function call arguments <arjan> if you pass big-ish structures to functions things get skewed quickly
<arjan> the caller pushes the arguments
<arjan> just before the 'call'

and also:

<arjan> btw one thing that helps modern gcc is to move variable declarations into the inner most {} scope possible <sandeen> does it really help?
<arjan> it'll allow it to share stack slots
<sandeen> older gccs that was actually -worse- <arjan> yes
<sandeen> xfs was originally largely written that way <sandeen> how recent?
<arjan> 4.1 and later have this fixed

lots of irix xfs was written this way IIRC, but I think things got moved out. Maybe it'd help to move them back in, for things like xfs_bmapi...

although it's a -penalty- for older gcc's still I think.

Anyway, just found that interesting, might help us get some of this under control without a huge amount of refactoring...

-Eric