Skip to contentSkip to conversation

cell: fix missing spu.h header export

PATCH In review Geoff Levand 2 participants 5 messages Dec 5, 2006 – Dec 6, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cell: fix missing spu.h header export

Add spu.h to the list of exported headers. Fixes this error when using 'make headers_check' or when CONFIG_HEADERS_CHECK=y:

asm/spu_info.h requires asm/spu.h, which does not exist in exported headers

---
 include/asm-powerpc/Kbuild |    1 +
 1 files changed, 1 insertion(+)
include/asm-powerpc/Kbuild +1 -0
@@ -37,6 +37,7 @@ unifdef-y += posix_types.h
 unifdef-y += ptrace.h
 unifdef-y += seccomp.h
 unifdef-y += signal.h
+unifdef-y += spu.h
 unifdef-y += termios.h
 unifdef-y += types.h
 unifdef-y += unistd.h
#1 lore raw
Quoted 5 lines · Geoff Levand

=20
Add spu.h to the list of exported headers. =A0Fixes this error when using 'make headers_check' or when CONFIG_HEADERS_CHECK=3Dy:
=20
=A0 asm/spu_info.h requires asm/spu.h, which does not exist in exported h=

eaders

Quoted 3 lines

=20
=20

Sorry, wrong fix. I had a better one already but haven't gotten around to post it. spu_info.h should be in unifdef-y and spu.h should stay internal to the kernel. I'll follow up with my patch.

	Arnd <><
#2 lore raw
Quoted 3 lines · Arnd Bergmann
Quoted 2 lines · Geoff Levand

=20
Add spu.h to the list of exported headers. =EF=BF=BDFixes this error w=

hen

Quoted 3 lines
Quoted 3 lines

using 'make headers_check' or when CONFIG_HEADERS_CHECK=3Dy:
=20
=EF=BF=BD asm/spu_info.h requires asm/spu.h, which does not exist in e=

xported headers

Quoted 7 lines
Quoted 3 lines

=20
=20

=20
Sorry, wrong fix. I had a better one already but haven't gotten around to post it. spu_info.h should be in unifdef-y and spu.h should stay internal to the kernel. I'll follow up with my patch.

Dang your fast, I was just going to post that!

#3 lore raw

PATCH 1/1 cell: fix spu_info.h header export

It uses #ifdef __KERNEL__, so needs to be processes with unifdef

include/asm-powerpc/Kbuild +1 -1
Index: linux-2.6/include/asm-powerpc/Kbuild
===================================================================
@@ -17,7 +17,6 @@ header-y += ipc.h
 header-y += poll.h
 header-y += shmparam.h
 header-y += sockios.h
-header-y += spu_info.h
 header-y += ucontext.h
 header-y += ioctl.h
 header-y += linkage.h
@@ -37,6 +36,7 @@ unifdef-y += posix_types.h
 unifdef-y += ptrace.h
 unifdef-y += seccomp.h
 unifdef-y += signal.h
+unifdef-y += spu_info.h
 unifdef-y += termios.h
 unifdef-y += types.h
 unifdef-y += unistd.h