Skip to contentSkip to conversation

kernel/sched.c:4135: error: 'notick' undeclared

PATCH In review Pierre Peiffer 2 participants 2 messages Dec 14, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel/sched.c:4135: error: 'notick' undeclared

Hi,

The kernel (sched.c) does not compile if CONFIG_HZ and CONFIG_SMP are set, and CONFIG_NO_HZ isn't.

Is this patch correct ?

---

kernel/sched.c 2006-12-14 16:42:38.000000000 +0100 renamed from kernel/sched.c 2006-12-14 16:27:37.000000000 +0100 +1 -1
Index: linux-2.6.19-rt14-test/kernel/sched.c
===================================================================
@@ -4131,7 +4131,7 @@ switch_tasks:
                ++*switch_count;
 
                prepare_task_switch(rq, next);
-#if defined(CONFIG_HZ) && defined(CONFIG_SMP)
+#if defined(CONFIG_NO_HZ) && defined(CONFIG_SMP)
                if (prev == rq->idle && notick.load_balancer == -1) {
                        /*
                         * simple selection for now: Nominate the first cpu in

Thanks,

Signature · 1 line
Pierre Peiffer
#1 lore raw
Quoted 4 lines · Pierre Peiffer

Hi,

The kernel (sched.c) does not compile if CONFIG_HZ and CONFIG_SMP are set, and CONFIG_NO_HZ isn't.

oops - indeed.

Quoted 1 line

Is this patch correct ?

yeah. (FYI, i had to hand-apply it because it had whitespace damage, all tabs where spaces)

Ingo