ARM: Include compilation and warning fixes
PATCH 1/4 ARM: Include compilation and warning fixes
ARM: Fix compilation issues and warnings for CONFIG PREEMPT RT for ARM in include/asm-arm/system.h.
include/asm-arm/system.h +5 -5
@@ -173,23 +173,25 @@ static inline void set_copro_access(unsiextern unsigned long cr_no_alignment;/* defined in entry-armv.S */ extern unsigned long cr_alignment;/* defined in entry-armv.S */ +#include <linux/irqflags.h> +#ifndef CONFIG_SMP static inline void adjust_cr (unsigned long mask,unsigned long set) { -unsigned long flags, cr; +unsigned long flags; mask &= ~CR_A ; set &= mask; -local_irq_save (flags); +raw_local_irq_save (flags); cr_no_alignment = (cr_no_alignment & ~mask) | set; cr_alignment = (cr_alignment & ~mask) | set;set_cr ((get_cr () & ~mask) | set); -local_irq_restore (flags); +raw_local_irq_restore (flags); }#endif
@@ -248,8 +250,6 @@ static inline void sched_cacheflush(void { } -#include <linux/irqflags.h> -#ifdef CONFIG_SMP #define smp_mb () mb()
Quoted 5 lines · Dirk Behme
ARM: Fix compilation issues and warnings for CONFIG PREEMPT RT for ARM in
include/asm-arm/system.h.Signed-off-by Dirk Behme <dirk.behme_at_gmail.com>
Patches like this have been flying around for over a week now, but the bug's been fixed using a different approach. Unfortunately, Linus hasn't pulled the fixes yet, presumably due to being engrossed in fixing this data corruption issue.
Signature · 3 lines
Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of:
Quoted 11 lines · Russell King
Quoted 5 lines · Dirk Behme
ARM: Fix compilation issues and warnings for CONFIG PREEMPT RT for ARM in
include/asm-arm/system.h.Signed-off-by Dirk Behme <dirk.behme_at_gmail.com>Patches like this have been flying around for over a week now, but the bug's been fixed using a different approach. Unfortunately, Linus hasn't pulled the fixes yet, presumably due to being engrossed in fixing this data corruption issue.
update: it just into upstream -git to which i rebase daily, so i dropped the first patch and i'm relying on your fix now in -rt.
Ingo