Skip to contentSkip to conversation

ARM: OMAP: Make board-palmz71 compile again

PATCH In review Dirk Behme 2 participants 2 messages Jan 4, 2007 – Jan 9, 2007

Subsystems (3)
Arm (32-bit) Arm sub-architectures OMAP1 support
lore
Share & tools
lore

Dirk Behme

author
#0 lore raw

PATCH 1/1 ARM: OMAP: Make board-palmz71 compile again

ARM: OMAP: Fix compilation issues in board-palmz71.c

Signed-off-by Dirk Behme <dirk.behme_at_gmail.com>
arch/arm/mach-omap1/board-palmz71.c +2 -3
Index: linux-osk/arch/arm/mach-omap1/board-palmz71.c
===================================================================
@@ -260,7 +260,6 @@ static struct spi_board_info __initdata 
 				* 26	/* command + data + overhead */,
 	.bus_num	= 2,
 	.chip_select	= 0,
-	}
 } };
 
 static struct omap_usb_config palmz71_usb_config __initdata = {

@@ -295,7 +294,7 @@ static struct omap_board_config_kernel p
 };
 
 static irqreturn_t
-palmz71_powercable(int irq, void *dev_id, struct pt_regs *regs)
+palmz71_powercable(int irq, void *dev_id)
 {
 	if (omap_get_gpio_datain(PALMZ71_USBDETECT_GPIO)) {
 		printk(KERN_INFO "PM: Power cable connected\n");

@@ -347,7 +346,7 @@ palmz71_gpio_setup(int early)
 				"palmz71-cable", 0))
 			printk(KERN_ERR
 			       "IRQ request for power cable failed!\n");
-		palmz71_powercable(OMAP_GPIO_IRQ(PALMZ71_USBDETECT_GPIO), 0, 0);
+		palmz71_powercable(OMAP_GPIO_IRQ(PALMZ71_USBDETECT_GPIO), 0);
 	}
 }
reviewer
#1 lore raw
Quoted 28 lines · Dirk Behme

ARM: OMAP: Fix compilation issues in board-palmz71.c

Signed-off-by Dirk Behme <dirk.behme_at_gmail.com>

Index: linux-osk/arch/arm/mach-omap1/board-palmz71.c
===================================================================

arch/arm/mach-omap1/board-palmz71.c +1 -2
@@ -260,7 +260,6 @@ static struct spi_board_info __initdata 
 				* 26	/* command + data + overhead */,
 	.bus_num	= 2,
 	.chip_select	= 0,
-	}
 } };
 
 static struct omap_usb_config palmz71_usb_config __initdata = {

@@ -295,7 +294,7 @@ static struct omap_board_config_kernel p
 };
 
 static irqreturn_t
-palmz71_powercable(int irq, void *dev_id, struct pt_regs *regs)
+palmz71_powercable(int irq, void *dev_id)
 {
 	if (omap_get_gpio_datain(PALMZ71_USBDETECT_GPIO)) {
 		printk(KERN_INFO "PM: Power cable connected\n");

arch/arm/mach-omap1/board-palmz71.c palmz71_gpio_setup(int early) · line 351

Quoted 7 lines
arch/arm/mach-omap1/board-palmz71.c +1 -1
@@ -347,7 +346,7 @@ palmz71_gpio_setup(int early)
 				"palmz71-cable", 0))
 			printk(KERN_ERR
 			       "IRQ request for power cable failed!\n");
-		palmz71_powercable(OMAP_GPIO_IRQ(PALMZ71_USBDETECT_GPIO), 0, 0);
+		palmz71_powercable(OMAP_GPIO_IRQ(PALMZ71_USBDETECT_GPIO), 0);
 	}
 }

Pushing today.

Tony