Skip to contentSkip to conversation

long disable of Softirqs in br_forward_delay_timer_expired()

DISCUSSION Juergen Pfeiffer 1 participant 2 messages Jan 18, 2007 – Jan 19, 2007

lore
Share & tools
lore
#0 lore raw

Hi

I had problems in my implementation of Profibus-protocol, because my FDL-State machine is implemented in tasklets and sometimes there were situations, where Soft-Irqs were disabled for 20-40mS (Coldfire 5485 / 96MHz). After inserting some testpoints in kernels source, doing dump_stack(), when the jiffie-time get longer then 20mS, i detected the place of the long Soft-Irq disable in function

static void br_forward_delay_timer_expired(..)
inside file "net/bridge/br_stp_timer.c"

It does a
spin_lock_bh(..);
... some functionality;
spin_unlock_bh(..);

Does anybody know, why the functionality inbetween lock/unlock takes so long (2-4 jiffies @ HZ=100)

Thank You

Juergen Pfeiffer,
Seskion GmbH
Karlsruher Str. 11/1
70771 Leinfelden-Echterdingen
Germany

[email protected]

www.seskion.de

#1 lore raw
Quoted 6 lines · Juergen Pfeiffer

I had problems in my implementation of Profibus-protocol, because my FDL-State machine is implemented in tasklets and sometimes there were situations, where Soft-Irqs were disabled for 20-40mS (Coldfire 5485 / 96MHz). After inserting some testpoints in kernels source, doing dump_stack(), when the jiffie-time get longer then 20mS, i detected the place of the long Soft-Irq disable in function

Quoted 7 lines

static void br_forward_delay_timer_expired(..)
inside file "net/bridge/br_stp_timer.c"

It does a
spin_lock_bh(..);
... some functionality;
spin_unlock_bh(..);

Hi

I found the reason for the long disabling of Soft-Irqs:

In-between the spin_lock_bh() and spin_unlock_bh() was a printk() going to serial console with 19200baud. So it took easily 30mS for console-output.

No i start klogd an the log Messages go to a file in tmpfs in a short time.

Juergen Pfeiffer,
Seskion GmbH
Karlsruher Str. 11/1
70771 Leinfelden-Echterdingen
Germany

[email protected]

www.seskion.de
------------------------------------------------------------------------