ARM: OMAP: Fix warnings in musb_procfs.c

ARM: OMAP: Fix warnings in musb_procfs.c:

drivers/usb/musb/musb_procfs.c: In function 'musb_proc_write':
drivers/usb/musb/musb_procfs.c:651: warning: ignoring return value of 'copy_from_user', declared with attribute warn_unused_result drivers/usb/musb/musb_procfs.c:725: warning: ignoring return value of 'copy_from_user', declared with attribute warn_unused_result

Signed-off-by Dirk Behme <dirk.behme_at_gmail.com>

------------------------------------------------------------------------

Index: linux-osk/drivers/usb/musb/musb_procfs.c
===================================================================

drivers/usb/musb/musb_procfs.c +6 -2

@@ -648,7 +648,8 @@ static int musb_proc_write(struct file *
 
 	/* MOD_INC_USE_COUNT; */
 
-	copy_from_user(&cmd, buffer, 1);
+	if(unlikely(copy_from_user(&cmd, buffer, 1)))
+		return -EFAULT;
 	switch (cmd) {
 	case 'C':
 		if (pBase) {

@@ -722,7 +723,10 @@ static int musb_proc_write(struct file *
 				int i = 0, level = 0, sign = 1;
 				int len = min(count - 1, (unsigned long)8);
 
-				copy_from_user(&digits, &buffer[1], len);
+				if(unlikely(copy_from_user(&digits,
+							   &buffer[1],
+							   len)))
+					return -EFAULT;
 
 				/* optional sign */
 				if (*p == '-') {

Quoted 1 line · Dirk Behme

ARM: OMAP: Fix warnings in musb_procfs.c:

What's about this one? Do I overlooked any comments?

It's the last one in my pending patches list ;)

Orginal post:

http://linux.omap.com/pipermail/linux-omap-open-source/2007-January/008903.html