Skip to contentSkip to conversation

EV_MSC / driver/input/input.c (Input Handler)

DISCUSSION Frank Salomon 2 participants 4 messages Feb 8, 2007 – Feb 9, 2007

lore
Share & tools
lore
#0 lore raw

Hi All,

I had written an additional input_handler :

     static struct input_device_id pcraw_ids[] = {
	     {
                     .flags = INPUT_DEVICE_ID_MATCH_EVBIT,
                     .evbit = { BIT(EV_MSC) },
             },
	     { },    /* Terminating entry */
     };

to get MSC_RAW events from the atkeyboard :

     input_event (&atkbd->dev, EV_MSC, MSC_RAW, code)

But I only get these events :

     input_event(&atkbd->dev, EV_MSC, MSC_SCAN, code);

I know the reason is in driver/input/input.c :

     case EV_MSC:
          if (code > MSC_MAX || !test_bit(code, dev->mscbit))
               return;

          if (dev->event) dev->event(dev, type, code, value);
          break;

because of (driver/input/keyboard/atkbd.c):

     atkbd->dev.mscbit[0] = atkbd->softraw ? BIT(MSC_SCAN) :
          BIT(MSC_RAW) | BIT(MSC_SCAN);

I would like to change driver/input/input.c like this :

     case EV_MSC:
          if (code > MSC_MAX)
               return;

          if (test_bit(code, dev->mscbit))
               if (dev->event) dev->event(dev, type, code, value);
          break;

Any comments ? Maybe I misunderstand the concept of the input events. In that case, please give me a short description or let me know were I can find any documentation.

Best regards, Frank

#1 lore raw
Quoted 12 lines · Frank Salomon

Hi All,

I had written an additional input_handler :

     static struct input_device_id pcraw_ids[] = {
            {
                     .flags = INPUT_DEVICE_ID_MATCH_EVBIT,
                     .evbit = { BIT(EV_MSC) },
             },
            { },    /* Terminating entry */
     };
Quoted 8 lines

to get MSC_RAW events from the atkeyboard :

     input_event (&atkbd->dev, EV_MSC, MSC_RAW, code)

But I only get these events :

     input_event(&atkbd->dev, EV_MSC, MSC_SCAN, code);

That is because by default atkbd uses software-emulated raw mode. bootk with atkbd.softraw=0 or switch it off after boot through sysfs attribute to get EV_MSC/MSC_RAW passed through).

Quoted 24 lines

I know the reason is in driver/input/input.c :

     case EV_MSC:
          if (code > MSC_MAX || !test_bit(code, dev->mscbit))
               return;

          if (dev->event) dev->event(dev, type, code, value);
          break;

because of (driver/input/keyboard/atkbd.c):

     atkbd->dev.mscbit[0] = atkbd->softraw ? BIT(MSC_SCAN) :
          BIT(MSC_RAW) | BIT(MSC_SCAN);

I would like to change driver/input/input.c like this :

     case EV_MSC:
          if (code > MSC_MAX)
               return;

          if (test_bit(code, dev->mscbit))
               if (dev->event) dev->event(dev, type, code, value);
          break;
Quoted 4 lines

Any comments ? Maybe I misunderstand the concept of the input events. In that case, please give me a short description or let me know were I can find any documentation.

No, input core should not pass any events device did not claim to support.

What are you trying to do though? Why are you interested in raw atkbd events? What will your handler do with events from other input devices that might emit raw events?

Signature · 1 line
Dmitry
#2 lore raw

Hi Dmitry,

Quoted 3 lines · Dmitry Torokhov

That is because by default atkbd uses software-emulated raw mode. bootk with atkbd.softraw=0 or switch it off after boot through sysfs attribute to get EV_MSC/MSC_RAW passed through).

Thank you for your advice, but I really don't know, what will be the secondary effect if it will be switched off.

Quoted 1 line

No, input core should not pass any events device did not claim to support.

I am not sure, but I think the function input_event in drivers/input/input.c has 2 tasks:
One is to send events to the device (first part: "switch (type){").

The other one is to send the events to the handler (second part: "list_for_each_entry(handle, &dev->h_list, d_node)").

This is the reason why I had the idea of changing the code as I have described it before.

With the current implementation, the device sends events to the handler. But only events, known/claimed by the device are passed through to the handler. I believe, this should be handled transparently.

Quoted 3 lines

What are you trying to do though? Why are you interested in raw atkbd events? What will your handler do with events from other input devices that might emit raw events?

I have to connected special Point Of Sales Keyboards. Sometimes they are sending none standard scan codes, only make codes and no break codes. I had successfully implemented this in kernel version 2.4 and now I have to do it in 2.6.

Best regards, Frank

#3 lore raw

Hi Frank,

Quoted 20 lines · Frank Salomon

Hi Dmitry,

Quoted 3 lines · Dmitry Torokhov

That is because by default atkbd uses software-emulated raw mode. bootk with atkbd.softraw=0 or switch it off after boot through sysfs attribute to get EV_MSC/MSC_RAW passed through).

Thank you for your advice, but I really don't know, what will be the secondary effect if it will be switched off.

Quoted 1 line

No, input core should not pass any events device did not claim to support.

I am not sure, but I think the function input_event in drivers/input/input.c has 2 tasks:
One is to send events to the device (first part: "switch (type){").

The other one is to send the events to the handler (second part:
"list_for_each_entry(handle, &dev->h_list, d_node)").

Quoted 7 lines

This is the reason why I had the idea of changing the code as I have described it before.

With the current implementation, the device sends events to the handler. But only events, known/claimed by the device are passed through to the handler. I believe, this should be handled transparently.

Thta is the policy. Unless device claims to support certain events they will not be passed through so there is no "surprises". This way userspace applications can query device capabilities, classify them and adjust behavior accordingly.

Quoted 9 lines
Quoted 3 lines

What are you trying to do though? Why are you interested in raw atkbd events? What will your handler do with events from other input devices that might emit raw events?

I have to connected special Point Of Sales Keyboards. Sometimes they are sending none standard scan codes, only make codes and no break codes. I had successfully implemented this in kernel version 2.4 and now I have to do it in 2.6.

You probably want to use serio_raw module for that that provides raw access to a PS/2 port (2.4-style) and possibly uinput driver to nject parsed event stream back into kernel for standard delivery to userspace apps.

Signature · 1 line
Dmitry